Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix base path maintenance task failure #789

Merged
merged 5 commits into from
Jan 31, 2025
Merged

Conversation

webfiltered
Copy link
Contributor

@webfiltered webfiltered commented Jan 30, 2025

Refactoring of ComfySettings instantiation has resulted in the base path maintenance task update not flowing through to the setting in that class.

Resolved by re-instantiating and reloading settings from disk when basePath is set.

┆Issue is synchronized with this Notion page by Unito

@webfiltered webfiltered requested a review from a team as a code owner January 30, 2025 20:31
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Jan 30, 2025
@webfiltered webfiltered merged commit fc6f8c5 into main Jan 31, 2025
7 checks passed
@webfiltered webfiltered deleted the ensure-base-path-updated branch January 31, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant