Make comfy settings instance accessible from anywhere #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
dosubot
bot
added
size:XL
christian-byrne
commented
Feb 8, 2025
| const comfySettings = new ComfySettings(installWizard.basePath); | ||
| await comfySettings.loadSettings(); | ||
| const installation = new ComfyInstallation('started', installWizard.basePath, this.telemetry, comfySettings); | ||
| const installation = new ComfyInstallation('started', installWizard.basePath, this.telemetry); | ||
| InstallationManager.setReinstallHandler(installation); |
There was a problem hiding this comment.
Previously, installWizard would read existing settings, add install options, then write, then installationManager would initialize settings.
Now, installWizard does the same as before but also initializes the settings instance at the same time, making it unecessary for installationManager to do it.
christian-byrne
changed the title
christian-byrne
changed the title
webfiltered
reviewed
Feb 8, 2025
| @@ -102,9 +115,13 @@ export class ComfySettings implements IComfySettings { | |||
| const fileContent = await fs.readFile(this.filePath, 'utf8'); | |||
| // TODO: Reimplement with validation and error reporting. | |||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment | |||
| this.settings = JSON.parse(fileContent); | |||
| this.settings = { ...this.settings, ...JSON.parse(fileContent) }; | |||
There was a problem hiding this comment.
Flagging just in case: Not sure if this is a runtime change to settings or not (e.g. if setting has been changed in existing user file then later reset, does this result in a net change?).
webfiltered
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ComfySettingsto use same initialization and access pattern asDesktopConfig, making the current instance accessible from any module.This enables the Sentry class to check whether the user consents to metrics during the installation process, so that installation errors can be manually captured and sent to Sentry. Previously, Sentry was not able to easily access the current settings instance.
┆Issue is synchronized with this Notion page by Unito