Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralise ANSI code removal to log transforms #884

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Centralise ANSI code removal to log transforms #884

merged 3 commits into from
Feb 10, 2025

Conversation

webfiltered
Copy link
Contributor

@webfiltered webfiltered commented Feb 10, 2025 •
edited by sync-by-unito bot
Loading

  • Prepended to transforms - ANSI filtering will now run before other transforms
  • Simplifies code
  • Removes double-filtering when sentry reads the log files back into memory

┆Issue is synchronized with this Notion page by Unito

@webfiltered webfiltered requested a review from a team as a code owner February 10, 2025 13:03
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 10, 2025
@webfiltered webfiltered enabled auto-merge (squash) February 10, 2025 13:03
@webfiltered
Copy link
Contributor Author

@christian-byrne Can you PTAL at b5055ea? Was this belt-and-braces, or did you find ANSI codes in logs recently?

christian-byrne
christian-byrne approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the ansi code removal in getLogTail was just precautionary. If it's not necessary, should be good to remove!

@webfiltered webfiltered merged commit 2b584e7 into main Feb 10, 2025
7 checks passed
@webfiltered webfiltered deleted the antsy-logging branch February 10, 2025 22:00
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-byrne christian-byrne christian-byrne approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webfiltered @christian-byrne