Skip to content

Commit

Permalink
Delete node version. (#127)
Browse files Browse the repository at this point in the history
  • Loading branch information
robinjhuang authored Jan 8, 2025
1 parent 865dea9 commit 4dc619c
Show file tree
Hide file tree
Showing 5 changed files with 163 additions and 111 deletions.
208 changes: 104 additions & 104 deletions drip/api.gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion openapi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -947,7 +947,7 @@ paths:
'204':
description: Version unpublished (deleted) successfully
'403':
description: Version not found
description: Version does not belong to the publisher
content:
application/json:
schema:
Expand Down
20 changes: 14 additions & 6 deletions server/implementation/registry.go
Original file line number Diff line number Diff line change
Expand Up @@ -557,12 +557,20 @@ func (s *DripStrictServerImplementation) PostNodeReview(ctx context.Context, req
func (s *DripStrictServerImplementation) DeleteNodeVersion(
ctx context.Context, request drip.DeleteNodeVersionRequestObject) (drip.DeleteNodeVersionResponseObject, error) {

// Directly return the message that node versions cannot be deleted
errMessage := "Cannot delete node versions. Please deprecate it instead."
log.Ctx(ctx).Warn().Msg(errMessage)
return drip.DeleteNodeVersion404JSONResponse{
Message: proto.String(errMessage),
}, nil
nodeVersion, err := s.RegistryService.GetNodeVersion(ctx, s.Client, request.VersionId)
if err != nil {
log.Ctx(ctx).Error().Msgf("Failed to get node version w/ err: %v", err)
return drip.DeleteNodeVersion404JSONResponse{Message: proto.String("Node version not found")}, nil
}

err = s.RegistryService.DeleteNodeVersion(ctx, s.Client, nodeVersion.ID.String())
if err != nil {
log.Ctx(ctx).Error().Msgf("Failed to delete node version w/ err: %v", err)
return drip.DeleteNodeVersion500JSONResponse{Message: "Failed to delete node version", Error: err.Error()}, err
}

log.Ctx(ctx).Info().Msgf("Node version %s deleted successfully", request.VersionId)
return drip.DeleteNodeVersion204Response{}, nil
}

func (s *DripStrictServerImplementation) GetNodeVersion(
Expand Down
Loading

0 comments on commit 4dc619c

Please sign in to comment.