Fix analyzers not running after generators

CommunityToolkit · Jan 2, 2025 · 034d8a4 · 034d8a4
1 parent 0bf8edd
commit 034d8a4
Show file tree

Hide file tree

Showing 7 changed files with 19 additions and 15 deletions.
diff --git a/...yGenerator.SourceGenerators/Diagnostics/Analyzers/ExplicitPropertyMetadataTypeAnalyzer.cs b/...yGenerator.SourceGenerators/Diagnostics/Analyzers/ExplicitPropertyMetadataTypeAnalyzer.cs
@@ -27,7 +27,7 @@ public sealed class ExplicitPropertyMetadataTypeAnalyzer : DiagnosticAnalyzer
     /// <inheritdoc/>
     public override void Initialize(AnalysisContext context)
     {
-        context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);
+        context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.Analyze | GeneratedCodeAnalysisFlags.ReportDiagnostics);
         context.EnableConcurrentExecution();
 
         context.RegisterCompilationStartAction(static context =>

diff --git a/...SourceGenerators/Diagnostics/Analyzers/InvalidPropertyDefaultValueCallbackTypeAnalyzer.cs b/...SourceGenerators/Diagnostics/Analyzers/InvalidPropertyDefaultValueCallbackTypeAnalyzer.cs
@@ -29,7 +29,7 @@ public sealed class InvalidPropertyDefaultValueCallbackTypeAnalyzer : Diagnostic
     /// <inheritdoc/>
     public override void Initialize(AnalysisContext context)
     {
-        context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);
+        context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.Analyze | GeneratedCodeAnalysisFlags.ReportDiagnostics);
         context.EnableConcurrentExecution();
 
         context.RegisterCompilationStartAction(static context =>
@@ -39,7 +39,11 @@ public override void Initialize(AnalysisContext context)
 
             context.RegisterSymbolAction(context =>
             {
-                IPropertySymbol propertySymbol = (IPropertySymbol)context.Symbol;
+                // Ensure that we have some target property to analyze (also skip implementation parts)
+                if (context.Symbol is not IPropertySymbol { PartialDefinitionPart: null } propertySymbol)
+                {
+                    return;
+                }
 
                 // If the property is not using '[GeneratedDependencyProperty]', there's nothing to do
                 if (!propertySymbol.TryGetAttributeWithAnyType(generatedDependencyPropertyAttributeSymbols, out AttributeData? attributeData))

diff --git a/...nerator.SourceGenerators/Diagnostics/Analyzers/InvalidPropertyDefaultValueTypeAnalyzer.cs b/...nerator.SourceGenerators/Diagnostics/Analyzers/InvalidPropertyDefaultValueTypeAnalyzer.cs
@@ -28,7 +28,7 @@ public sealed class InvalidPropertyDefaultValueTypeAnalyzer : DiagnosticAnalyzer
     /// <inheritdoc/>
     public override void Initialize(AnalysisContext context)
     {
-        context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);
+        context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.Analyze | GeneratedCodeAnalysisFlags.ReportDiagnostics);
         context.EnableConcurrentExecution();
 
         context.RegisterCompilationStartAction(static context =>
@@ -39,7 +39,7 @@ public override void Initialize(AnalysisContext context)
             context.RegisterOperationAction(context =>
             {
                 // We only care about attributes on properties
-                if (context.ContainingSymbol is not IPropertySymbol propertySymbol)
+                if (context.ContainingSymbol is not IPropertySymbol { PartialDefinitionPart: null } propertySymbol)
                 {
                     return;
                 }

diff --git a/...eGenerators/Diagnostics/Analyzers/InvalidPropertyForwardedAttributeDeclarationAnalyzer.cs b/...eGenerators/Diagnostics/Analyzers/InvalidPropertyForwardedAttributeDeclarationAnalyzer.cs
@@ -31,7 +31,7 @@ public sealed class InvalidPropertyForwardedAttributeDeclarationAnalyzer : Diagn
     /// <inheritdoc/>
     public override void Initialize(AnalysisContext context)
     {
-        context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);
+        context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.Analyze | GeneratedCodeAnalysisFlags.ReportDiagnostics);
         context.EnableConcurrentExecution();
 
         context.RegisterCompilationStartAction(static context =>

diff --git a/...rator.SourceGenerators/Diagnostics/Analyzers/InvalidPropertyNullableAnnotationAnalyzer.cs b/...rator.SourceGenerators/Diagnostics/Analyzers/InvalidPropertyNullableAnnotationAnalyzer.cs
@@ -29,7 +29,7 @@ public sealed class InvalidPropertyNullableAnnotationAnalyzer : DiagnosticAnalyz
     /// <inheritdoc/>
     public override void Initialize(AnalysisContext context)
     {
-        context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);
+        context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.Analyze | GeneratedCodeAnalysisFlags.ReportDiagnostics);
         context.EnableConcurrentExecution();
 
         context.RegisterCompilationStartAction(static context =>
@@ -46,7 +46,7 @@ public override void Initialize(AnalysisContext context)
             context.RegisterSymbolAction(context =>
             {
                 // Validate that we have a property that is of some type that could potentially become 'null'
-                if (context.Symbol is not IPropertySymbol { Type.IsValueType: false, NullableAnnotation: not NullableAnnotation.None } propertySymbol)
+                if (context.Symbol is not IPropertySymbol { PartialDefinitionPart: null, Type.IsValueType: false, NullableAnnotation: not NullableAnnotation.None } propertySymbol)
                 {
                     return;
                 }

diff --git a/...urceGenerators/Diagnostics/Analyzers/PropertyDeclarationWithPropertyNameSuffixAnalyzer.cs b/...urceGenerators/Diagnostics/Analyzers/PropertyDeclarationWithPropertyNameSuffixAnalyzer.cs
@@ -23,7 +23,7 @@ public sealed class PropertyDeclarationWithPropertyNameSuffixAnalyzer : Diagnost
     /// <inheritdoc/>
     public override void Initialize(AnalysisContext context)
     {
-        context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);
+        context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.Analyze | GeneratedCodeAnalysisFlags.ReportDiagnostics);
         context.EnableConcurrentExecution();
 
         context.RegisterCompilationStartAction(static context =>
@@ -33,7 +33,11 @@ public override void Initialize(AnalysisContext context)
 
             context.RegisterSymbolAction(context =>
             {
-                IPropertySymbol propertySymbol = (IPropertySymbol)context.Symbol;
+                // Ensure that we have some target property to analyze (also skip implementation parts)
+                if (context.Symbol is not IPropertySymbol { PartialDefinitionPart: null } propertySymbol)
+                {
+                    return;
+                }
 
                 // We only want to lookup the attribute if the property name actually ends with the 'Property' suffix
                 if (!propertySymbol.Name.EndsWith("Property"))

diff --git a/...erator.SourceGenerators/Diagnostics/Analyzers/UnsupportedCSharpLanguageVersionAnalyzer.cs b/...erator.SourceGenerators/Diagnostics/Analyzers/UnsupportedCSharpLanguageVersionAnalyzer.cs
@@ -44,11 +44,7 @@ public override void Initialize(AnalysisContext context)
 
             context.RegisterSymbolAction(context =>
             {
-                // Ensure that we have some target property to analyze (also skip implementation parts)
-                if (context.Symbol is not IPropertySymbol { PartialDefinitionPart: null } propertySymbol)
-                {
-                    return;
-                }
+                IPropertySymbol propertySymbol = (IPropertySymbol)context.Symbol;
 
                 // If the property is not using '[GeneratedDependencyProperty]', there's nothing to do
                 if (!propertySymbol.TryGetAttributeWithAnyType(generatedDependencyPropertyAttributeSymbols, out AttributeData? attributeData))