Merge pull request #632 from CommunityToolkit/user/sergiopedri/dp-gen…

…erator-fixes Minor '[GeneratedDependencyProperty]' fixes
CommunityToolkit · Jan 28, 2025 · 5834450 · 5834450
2 parents 0245b0e + e8f26b0
commit 5834450
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/...olkit.DependencyPropertyGenerator.SourceGenerators/DependencyPropertyGenerator.Execute.cs b/...olkit.DependencyPropertyGenerator.SourceGenerators/DependencyPropertyGenerator.Execute.cs
@@ -1053,7 +1053,7 @@ public static void WriteAdditionalTypes(EquatableArray<DependencyPropertyInfo> p
                     if (propertyInfo.IsSharedPropertyChangedCallbackImplemented)
                     {
                         writer.IncreaseIndent();
-                        writer.WriteLine($"PropertyChangedUnsafeAccessors.On{propertyInfo.PropertyName}PropertyChanged(__this, e);");
+                        writer.WriteLine("PropertyChangedUnsafeAccessors.OnPropertyChanged(__this, e);");
                         writer.DecreaseIndent();
                     }
 

diff --git a/...or/CommunityToolkit.DependencyPropertyGenerator.Tests/Test_DependencyPropertyGenerator.cs b/...or/CommunityToolkit.DependencyPropertyGenerator.Tests/Test_DependencyPropertyGenerator.cs
@@ -1454,7 +1454,7 @@ private void OnNumberPropertyChanged(DependencyObject d, DependencyPropertyChang
                         global::MyNamespace.MyControl __this = (global::MyNamespace.MyControl)d;
 
                         PropertyChangedUnsafeAccessors.OnNumberPropertyChanged(__this, e);
-                        PropertyChangedUnsafeAccessors.OnNumberPropertyChanged(__this, e);
+                        PropertyChangedUnsafeAccessors.OnPropertyChanged(__this, e);
                     }
                 }
 
@@ -3272,7 +3272,7 @@ private void OnFirstNamePropertyChanged(DependencyObject d, DependencyPropertyCh
                         global::MyNamespace.MyControl __this = (global::MyNamespace.MyControl)d;
 
                         PropertyChangedUnsafeAccessors.OnFirstNamePropertyChanged(__this, e);
-                        PropertyChangedUnsafeAccessors.OnFirstNamePropertyChanged(__this, e);
+                        PropertyChangedUnsafeAccessors.OnPropertyChanged(__this, e);
                     }
 
                     /// <inheritdoc cref="cref="global::MyNamespace.MyControl.OnPropertyChanged""/>
@@ -3555,7 +3555,7 @@ private void OnFirstNamePropertyChanged(DependencyObject d, DependencyPropertyCh
                         global::MyNamespace.MyControl __this = (global::MyNamespace.MyControl)d;
 
                         PropertyChangedUnsafeAccessors.OnFirstNamePropertyChanged(__this, e);
-                        PropertyChangedUnsafeAccessors.OnFirstNamePropertyChanged(__this, e);
+                        PropertyChangedUnsafeAccessors.OnPropertyChanged(__this, e);
                     }
 
                     /// <inheritdoc cref="cref="global::MyNamespace.MyControl.OnPropertyChanged""/>
@@ -3564,7 +3564,7 @@ private void OnLastNamePropertyChanged(DependencyObject d, DependencyPropertyCha
                         global::MyNamespace.MyControl __this = (global::MyNamespace.MyControl)d;
 
                         PropertyChangedUnsafeAccessors.OnLastNamePropertyChanged(__this, e);
-                        PropertyChangedUnsafeAccessors.OnLastNamePropertyChanged(__this, e);
+                        PropertyChangedUnsafeAccessors.OnPropertyChanged(__this, e);
                     }
                 }
 

diff --git a/components/DependencyPropertyGenerator/src/GeneratedDependencyProperty.cs b/components/DependencyPropertyGenerator/src/GeneratedDependencyProperty.cs
@@ -17,7 +17,7 @@ public sealed class GeneratedDependencyProperty
 {
     /// <summary><inheritdoc cref="DependencyProperty.UnsetValue"/></summary>
     /// <remarks>
-    /// This constant is only meant to be used in assignments to <see cref="DefaultValue"/> (because <see cref="DependencyProperty.UnsetValue"/>
+    /// This constant is only meant to be used in assignments to <see cref="GeneratedDependencyPropertyAttribute.DefaultValue"/> (because <see cref="DependencyProperty.UnsetValue"/>
     /// cannot be used in that context, as it is not a constant, but rather a static field). Using this constant in other scenarios is undefined behavior.
     /// </remarks>
     public const object UnsetValue = null!;