Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rating view #2191

Merged
merged 196 commits into from
Feb 14, 2025
Merged
Changes from 1 commit
Commits
Show all changes
196 commits
Select commit Hold shift + click to select a range
2a25d1d
Implemented basic TemplatedView.
GeorgeLeithead Aug 21, 2024
b42e811
Added better properties.
GeorgeLeithead Aug 23, 2024
467e145
Implemented Element abstraction
GeorgeLeithead Aug 30, 2024
ec26921
Merge branch 'CommunityToolkit:main' into RatingView
GeorgeLeithead Aug 30, 2024
e7d947f
Moved more to the Item Element
GeorgeLeithead Aug 30, 2024
fce062f
Renamed Inspirations to Showcase
GeorgeLeithead Sep 2, 2024
1662b75
Added most of the unit tests
GeorgeLeithead Sep 4, 2024
a7293e2
Fixed the filled, partially filled and empty.
GeorgeLeithead Sep 5, 2024
859ffba
Fixed the filled, partially filled, empty colors.
GeorgeLeithead Sep 5, 2024
7e8ce5b
Added EventArgs for rating changed
GeorgeLeithead Sep 6, 2024
50cfa05
Made event handler visible in C# markup
GeorgeLeithead Sep 9, 2024
3b0decf
Merge from MAIN
GeorgeLeithead Sep 9, 2024
ecc4b29
Fixed the unit test
GeorgeLeithead Sep 9, 2024
cd64619
Tidy up
GeorgeLeithead Sep 9, 2024
c432d11
Fixed IsEnabled binding and add/remove of gesture recognisers.
GeorgeLeithead Sep 9, 2024
0956abd
Undone some un-wanted changes
GeorgeLeithead Sep 9, 2024
5dba38c
Removed file from original implementation.
GeorgeLeithead Sep 9, 2024
69910a7
We don't need the enum int assigned
GeorgeLeithead Sep 9, 2024
31e91bb
Finished the XAML samples page.
GeorgeLeithead Sep 9, 2024
6be86b9
Further work on the C# syntax samples page.
GeorgeLeithead Sep 11, 2024
c648dc8
Merge branch 'main' into RatingView
GeorgeLeithead Sep 11, 2024
2faac26
Merge branch 'CommunityToolkit:main' into RatingView
GeorgeLeithead Sep 17, 2024
cf9be24
Fixed issue with backgrounds not being set correctly when rating chan…
GeorgeLeithead Sep 17, 2024
dbdf9cc
Removed un-completed Showcase
GeorgeLeithead Sep 18, 2024
97c961b
If CustomShape is NullOrEmpty default to Star.
GeorgeLeithead Sep 18, 2024
a9e9d10
Removed Theory test for Star
GeorgeLeithead Sep 18, 2024
139d0fe
Fixed type in unit test value check
GeorgeLeithead Sep 18, 2024
1ecf9d8
Merge branch 'CommunityToolkit:main' into RatingView
GeorgeLeithead Sep 18, 2024
8d5fd85
Moved all tests to Fluid Assertions
GeorgeLeithead Sep 18, 2024
834e4c3
Removed redundant code
GeorgeLeithead Sep 19, 2024
9a1a8dd
Fixed issue with Item fill.
GeorgeLeithead Sep 19, 2024
31b12ed
Completed C# syntax samples page, to match XAML
GeorgeLeithead Sep 19, 2024
212bdf7
Merge branch 'main' into RatingView
GeorgeLeithead Sep 19, 2024
0efff16
Merge updated with main.
GeorgeLeithead Sep 19, 2024
e4a46c0
Fixed issue with Spacing not being applied.
GeorgeLeithead Sep 20, 2024
596839e
Added new Custom shape example
GeorgeLeithead Sep 20, 2024
eb79b40
Updated shapes sample.
GeorgeLeithead Sep 20, 2024
0a60d17
Reduced unit test duration by 112ms
GeorgeLeithead Sep 20, 2024
11694dc
Changed property IsEnabled to IsReadOnly
GeorgeLeithead Sep 20, 2024
8de6547
Renamed EmptyColorProperty to EmptyProperty
GeorgeLeithead Sep 20, 2024
b6c09c7
Merge branch 'main' into RatingView
pictos Sep 22, 2024
41c452c
Update src/CommunityToolkit.Maui.Core/Interfaces/RatingView/IRatingVi…
GeorgeLeithead Sep 23, 2024
64986ba
Eliminated nullable forgiver.
GeorgeLeithead Sep 23, 2024
fcae236
Added property validator to RatingProperty, to make sure is in range.
GeorgeLeithead Sep 23, 2024
66263c3
Refactored PartialFill into method
GeorgeLeithead Sep 23, 2024
11df9d2
Changed RatingViewShape to a sealed class with private constructor.
GeorgeLeithead Sep 23, 2024
c0b9eec
Fixed light mode sample display issue
GeorgeLeithead Sep 25, 2024
0e56a9d
Simplified updating item fill.
GeorgeLeithead Sep 25, 2024
1177332
Set child background color
GeorgeLeithead Sep 25, 2024
fb8ea88
Merge branch 'main' into RatingView
pictos Sep 26, 2024
66ce357
Updated unit tests to mirror code changes.
GeorgeLeithead Sep 27, 2024
07238a1
Merge branch 'RatingView' of https://github.com/GeorgeLeithead/Commun…
GeorgeLeithead Sep 27, 2024
d5e4f25
Improved Code Coverage
GeorgeLeithead Sep 27, 2024
c351c8f
Merge branch 'CommunityToolkit:main' into RatingView
GeorgeLeithead Sep 27, 2024
c325afe
Alphabetize
TheCodeTraveler Sep 30, 2024
f70caa7
Refactor C# RatingView Page
TheCodeTraveler Oct 1, 2024
65a46be
Fix RatingView XAML Logic
TheCodeTraveler Oct 1, 2024
a2087e6
Add Default Rating
TheCodeTraveler Oct 1, 2024
45e79b2
Merge branch 'main' into RatingView
TheCodeTraveler Oct 1, 2024
cc504d4
`dotnet format`
TheCodeTraveler Oct 1, 2024
839a186
Merge branch 'RatingView' of https://github.com/GeorgeLeithead/Commun…
TheCodeTraveler Oct 1, 2024
4f1470b
Remove duplicate `RatingViewShowcaseViewModel` reference
TheCodeTraveler Oct 1, 2024
6fdc74e
Fix `Shape padding` bindings
TheCodeTraveler Oct 1, 2024
904076f
Use One-time Binding
TheCodeTraveler Oct 1, 2024
2dafe9b
Sample adjusted to fix on Pixel6. Fixed discrepancy between C# and XA…
GeorgeLeithead Oct 1, 2024
9b09e3c
Merge branch 'RatingView' of https://github.com/GeorgeLeithead/Commun…
TheCodeTraveler Oct 1, 2024
b760796
Update Picker Bindings
TheCodeTraveler Oct 1, 2024
1a23339
Fix Bug causing `event MaximumRating` to fire for multiple RatingViews
TheCodeTraveler Oct 1, 2024
8cafe3e
Put Slider + Value in same Row, Remove Unused Code
TheCodeTraveler Oct 1, 2024
d5c385d
Add lower bounds to `ShapeBorderThickness`
TheCodeTraveler Oct 1, 2024
00f77be
Remove `Debug.Assert`, Remove Null-Forgiving Operator (`!`), `byte` -…
TheCodeTraveler Oct 1, 2024
ff638e7
Remove `_ = `
TheCodeTraveler Oct 1, 2024
9f5f957
Remove `VerticalStackLayout`
TheCodeTraveler Oct 1, 2024
6e7778e
Add Additional ArgumentOutOfRangeException Tests
TheCodeTraveler Oct 1, 2024
c7f322e
Remove `HorizontalLayout`
TheCodeTraveler Oct 1, 2024
8b07d93
Remove `Auto`
TheCodeTraveler Oct 1, 2024
8eb51fb
Rename `Shape` -> `ItemShape` + `SizeProperty` -> `ItemShapeSizePrope…
TheCodeTraveler Oct 1, 2024
ebbb059
Update RatingViewTests.cs
TheCodeTraveler Oct 1, 2024
941d413
Simplified XAML view model and aligned XAML page with C# page
GeorgeLeithead Oct 2, 2024
6972f26
As Control is internal, it can not be modified externally.
GeorgeLeithead Oct 3, 2024
2fd09ce
Fixed some formatting issues
GeorgeLeithead Oct 3, 2024
ccf04b1
Added additional tests around AllowNULL
GeorgeLeithead Oct 3, 2024
e9bf052
Returned Showcase 'Provide a rating' back to 0.
GeorgeLeithead Oct 7, 2024
be15914
Returned Showcase review summary average back to 0
GeorgeLeithead Oct 7, 2024
603e619
Set maximum rating limit to 10
GeorgeLeithead Oct 7, 2024
54d481e
Fixed stepper and picker row heights in cSharp sample
GeorgeLeithead Oct 7, 2024
0a7e617
Remove un-necessary ICommand
GeorgeLeithead Oct 7, 2024
b1c85da
Added Toast to XAML sample
GeorgeLeithead Oct 7, 2024
b162a45
Merge branch 'CommunityToolkit:main' into RatingView
GeorgeLeithead Oct 7, 2024
f6d8f4a
Fixed rating maximumum limit use
GeorgeLeithead Oct 7, 2024
a9a7d3f
Improved branch coverage unit testing
GeorgeLeithead Oct 7, 2024
68f28c4
Merge branch 'main' into RatingView
GeorgeLeithead Oct 14, 2024
acc2a7d
Minor code clean up
GeorgeLeithead Oct 24, 2024
76463a9
Merge remote-tracking branch 'origin/RatingView' into RatingView
GeorgeLeithead Oct 24, 2024
b2a238e
Merge branch 'CommunityToolkit:main' into RatingView
GeorgeLeithead Oct 24, 2024
2903ba3
Fix for CsWinRT1030 and AOT
GeorgeLeithead Oct 25, 2024
ff62404
Moved PropertyChanged to main class as requested
GeorgeLeithead Oct 25, 2024
a279704
Fixed incorrect cast
GeorgeLeithead Oct 25, 2024
7233402
Merge branch 'CommunityToolkit:main' into RatingView
GeorgeLeithead Nov 7, 2024
6509b56
Merge branch 'CommunityToolkit:main' into RatingView
GeorgeLeithead Nov 12, 2024
928990a
Merge branch 'CommunityToolkit:main' into RatingView
GeorgeLeithead Nov 25, 2024
87acda1
Merge branch 'CommunityToolkit:main' into RatingView
GeorgeLeithead Dec 10, 2024
22cdce3
Update src/CommunityToolkit.Maui.Core/Primitives/RatingChangedEventAr…
TheCodeTraveler Dec 10, 2024
59438d3
Added a Roslyn analyser to validate MaximumRating property
GeorgeLeithead Dec 11, 2024
fb7d8d3
Merge branch 'main' into RatingView
TheCodeTraveler Dec 18, 2024
918d9a4
Resolved compiled bindings
GeorgeLeithead Dec 18, 2024
1258843
Minor style alignments.
GeorgeLeithead Dec 19, 2024
cb58f80
Resolved partial properties issue with AOT.
GeorgeLeithead Dec 19, 2024
d17b507
Merge branch 'main' into RatingView
TheCodeTraveler Dec 27, 2024
73204cd
Update Analyzer
TheCodeTraveler Dec 27, 2024
77b5a0b
Add Lower-Bounds test
TheCodeTraveler Dec 28, 2024
263e9e0
Add Benchmarks
TheCodeTraveler Dec 28, 2024
20c30f4
Remove duplicate rule
TheCodeTraveler Dec 28, 2024
0821ae7
Improve Analyzer Performance
TheCodeTraveler Dec 28, 2024
779c612
Fixed Analyzer and CodeFix to show the LightBulb
GeorgeLeithead Jan 7, 2025
716f0ce
Merge branch 'CommunityToolkit:main' into RatingView
GeorgeLeithead Jan 7, 2025
fa8ceb9
Merge branch 'main' into RatingView
pictos Jan 14, 2025
f465c39
Merge branch 'main' into RatingView
TheCodeTraveler Jan 15, 2025
bac6405
Move `RatingFillElement` to `CommunityToolkit.Maui.Core`, Replace `ov…
TheCodeTraveler Jan 15, 2025
71e55c9
Remove `_ = ` pattern
TheCodeTraveler Jan 15, 2025
99427a5
Ensure `Control.BindingContext` always matches `RatingView.BindingCon…
TheCodeTraveler Jan 15, 2025
f33615d
Avoid Using Reflection when Initializing `RatingView.ControlTemplate`
TheCodeTraveler Jan 15, 2025
2e1ede3
Rename `RatingView.Control` -> `RatingView.RatingLayout`, Make `Ratin…
TheCodeTraveler Jan 15, 2025
b5a649f
Fix XML Comments
TheCodeTraveler Jan 15, 2025
2917430
Merge branch 'main' into RatingView
TheCodeTraveler Jan 15, 2025
3d66c41
Remove Unused Code
TheCodeTraveler Jan 15, 2025
f1b4366
Use `[ObservableProperty]` and partial properties, Consolidate Rating…
TheCodeTraveler Jan 15, 2025
c14974c
Merge branch 'RatingView' of https://github.com/GeorgeLeithead/Commun…
TheCodeTraveler Jan 15, 2025
08ee749
Update AnalyzerReleases.Shipped.md
TheCodeTraveler Jan 15, 2025
26f1182
Use nested class
TheCodeTraveler Jan 16, 2025
d506bd3
Ensure `event RatingChanged` fires every time `Rating` changes
TheCodeTraveler Jan 16, 2025
9d2bea8
Fix failing tests
TheCodeTraveler Jan 16, 2025
217e07f
Update Namings + Formatting, Remove non-required XML Comments
TheCodeTraveler Jan 16, 2025
4f4b5fb
Merge branch 'main' into RatingView
TheCodeTraveler Jan 23, 2025
662d8ad
Removed CodeFixer.
GeorgeLeithead Jan 28, 2025
656df0a
Merged
GeorgeLeithead Jan 28, 2025
10a5a06
Fixed merge hell.
GeorgeLeithead Jan 28, 2025
4a76da8
Minor clean-up and re-arrange.
GeorgeLeithead Jan 29, 2025
ff34719
Merge branch 'main' into RatingView
TheCodeTraveler Jan 29, 2025
a0a122f
Merge branch 'main' into RatingView
TheCodeTraveler Jan 29, 2025
9a9613c
Short test duration for failing tests.
GeorgeLeithead Jan 31, 2025
18d656c
Un-done changes to unit tests for build tests.
GeorgeLeithead Jan 31, 2025
c2f7c34
Merge branch 'CommunityToolkit:main' into RatingView
GeorgeLeithead Feb 3, 2025
dce336d
Trying a single thread/worker to be used for parallelization tests.
GeorgeLeithead Feb 3, 2025
f7f6ec3
Added <TestTfmsInParallel>false</TestTfmsInParallel>
GeorgeLeithead Feb 3, 2025
dc6806d
Removed <TestTfmsInParallel>false</TestTfmsInParallel>
GeorgeLeithead Feb 3, 2025
84c0d0e
Merge branch 'CommunityToolkit:main' into RatingView
GeorgeLeithead Feb 5, 2025
1b7efa2
Merge branch 'CommunityToolkit:main' into RatingView
GeorgeLeithead Feb 6, 2025
450a22b
Fix DrawingViewViewModel Errors
TheCodeTraveler Feb 7, 2025
652b342
Merge branch 'CommunityToolkit:main' into RatingView
GeorgeLeithead Feb 10, 2025
85380c3
Merged
GeorgeLeithead Feb 10, 2025
1ea8764
Merged
GeorgeLeithead Feb 10, 2025
de4875f
Merge issues
GeorgeLeithead Feb 10, 2025
91316af
Merge Issues - Copy from Main
GeorgeLeithead Feb 10, 2025
e02be4e
Merge branch 'main' into RatingView
TheCodeTraveler Feb 11, 2025
188376b
Revert changes
TheCodeTraveler Feb 11, 2025
e6ecedb
Remove `RatingViewShapeHandler`
TheCodeTraveler Feb 11, 2025
8c6f01a
Merge branch 'RatingView' of https://github.com/GeorgeLeithead/Commun…
TheCodeTraveler Feb 11, 2025
da01997
Remove `IRatingViewShape`
TheCodeTraveler Feb 11, 2025
39d5a04
Fix Test
TheCodeTraveler Feb 11, 2025
456921b
Rename `RatingViewShapes` -> `RatingViewShape`
TheCodeTraveler Feb 11, 2025
2e17d98
Format
TheCodeTraveler Feb 11, 2025
3ed9a95
Update Naming
TheCodeTraveler Feb 11, 2025
6633325
Remove duplicate method
TheCodeTraveler Feb 11, 2025
bb80d16
Update Naming
TheCodeTraveler Feb 11, 2025
732c33e
Revert "Remove duplicate method"
TheCodeTraveler Feb 11, 2025
b82355f
Update formatting
TheCodeTraveler Feb 11, 2025
c8dee89
Merge branch 'main' into pr/2191
TheCodeTraveler Feb 11, 2025
0e1160c
Resolve merge conflict
TheCodeTraveler Feb 11, 2025
12cc2b6
Fixed broken unit test.
GeorgeLeithead Feb 12, 2025
c4b4ac8
Removed extra spacing
GeorgeLeithead Feb 12, 2025
e00bba1
Cleaned XAML sample code-behind
GeorgeLeithead Feb 12, 2025
f0a3f34
Merge branch 'main' into RatingView
TheCodeTraveler Feb 13, 2025
d8a61ab
Refactor `StepperMaximumRating_RatingChanged`
TheCodeTraveler Feb 13, 2025
7d94747
Rename `RatingFillElement` -> `RatingViewTapFill`
TheCodeTraveler Feb 13, 2025
b7dfa4a
Merge branch 'RatingView' of https://github.com/GeorgeLeithead/Commun…
TheCodeTraveler Feb 13, 2025
e73c1b8
Update Naming + XML Comments
TheCodeTraveler Feb 13, 2025
908207e
Update NuGet Packages
TheCodeTraveler Feb 13, 2025
7017150
Rename to `FillWhenTapped`
TheCodeTraveler Feb 13, 2025
ce086a2
Move `PathShapes` to partial class
TheCodeTraveler Feb 13, 2025
e710327
Add VerifyIncludedShapePaths Unit Test
TheCodeTraveler Feb 13, 2025
3b6088d
Update CommunityToolkit.Maui.Analyzers.Benchmarks.csproj
TheCodeTraveler Feb 13, 2025
072b2df
Fix NullReferenceException
TheCodeTraveler Feb 13, 2025
9870808
Rename to `FillOption` and `FillColor`
TheCodeTraveler Feb 13, 2025
e2ce133
Merge branch 'main' into RatingView
TheCodeTraveler Feb 13, 2025
53fd9c9
`dotnet format`
TheCodeTraveler Feb 13, 2025
9072986
Merge branch 'main' into RatingView
TheCodeTraveler Feb 13, 2025
b5f37d3
Merge branch 'main' into RatingView
TheCodeTraveler Feb 13, 2025
61ede6d
Removed redundant null check.
GeorgeLeithead Feb 14, 2025
9822905
Updated summery comment.
GeorgeLeithead Feb 14, 2025
3131395
Eliminated potential binding issues with using the BindingContext dir…
GeorgeLeithead Feb 14, 2025
5f2ac45
Merge branch 'CommunityToolkit:main' into RatingView
GeorgeLeithead Feb 14, 2025
be6da5e
Use view model instead of BindingContext.
GeorgeLeithead Feb 14, 2025
0dea633
Comment clean up and remove unused using
GeorgeLeithead Feb 14, 2025
62cd6d4
Ordered properties.
GeorgeLeithead Feb 14, 2025
e215459
Merge branch 'RatingView' of https://github.com/GeorgeLeithead/Commun…
GeorgeLeithead Feb 14, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into RatingView
TheCodeTraveler authored Jan 15, 2025
commit 2917430dac9a2d3c9a53faa433aa65fa73b5df49

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.