Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change reroute behaviour on trimmed paths #2762

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lewri
Copy link
Member

@lewri lewri commented Jan 18, 2025

Fixes #2501

Describe what the proposed change does

  • Adds a new parameter to the Walk action where a trimmed path issued
  • Instead of attempting a reroute inside the Walk, the action is finished instead
  • In the case of SeekReception, that action calls a new Walk with an updated path.

@Alberth289346 and I discussed this one, and both agree currently there may not be a very nice way to do this, but as it's a regression of #1852 introduced in 0.67 it may be worth considering a fix for now. A better long term solution is recoding how walk is handled as a whole.

@Alberth289346
Copy link
Contributor

I like the solution, good work !

@lewri lewri changed the title [RFC] Change reroute behaviour on trimmed patrhs [RFC] Change reroute behaviour on trimmed paths Jan 19, 2025
@lewri
Copy link
Member Author

lewri commented Jan 19, 2025

Not sure if @mugmuggy is about but his input would be nice to know too before making this ready.

@lewri lewri changed the title [RFC] Change reroute behaviour on trimmed paths Change reroute behaviour on trimmed paths Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

[Bug] Spawning patients do not check for blocked path before truncate
2 participants