Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstractcosmoemu #25

Merged
merged 13 commits into from
Aug 31, 2024
Merged

Abstractcosmoemu #25

merged 13 commits into from
Aug 31, 2024

Conversation

marcobonici
Copy link
Member

In this pull request, we have improved the calculation of the comoving distance:

  • We have removed QuadGK, using instead Integrals. The integrations algorithm employed is the same, but the latter has rules for AD.
  • We have added a faster integration method, based on FastGaussQuadrature.gausslegendre. This is tested against the former, adaptive method.

@marcobonici marcobonici self-assigned this Aug 31, 2024
Copy link

codecov bot commented Aug 31, 2024

Codecov Report

Attention: Patch coverage is 82.85714% with 6 lines in your changes missing coverage. Please review.

Project coverage is 30.71%. Comparing base (9a392b4) to head (bc4c4cc).
Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
src/background.jl 78.57% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #25      +/-   ##
===========================================
+ Coverage    25.72%   30.71%   +4.99%     
===========================================
  Files            5        7       +2     
  Lines          381      407      +26     
===========================================
+ Hits            98      125      +27     
+ Misses         283      282       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcobonici marcobonici merged commit 61ce479 into develop Aug 31, 2024
7 checks passed
@marcobonici marcobonici linked an issue Sep 1, 2024 that may be closed by this pull request
@marcobonici marcobonici deleted the abstractcosmoemu branch September 1, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Background quantities evaluation differentiation
1 participant