Set Block2 M bit to zero in the request #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation copies the Block2 option from the response, increments the block number, and adds it to the next request in the block transfer. This is done when then M bit in the Block2 option from the response is set, which means that the bit is set when cloned and added back to the request. To be compliant with RFC-7959, set the M bit to zero before adding it back to the request. Excerpt from RFC-7959: "In a request, the client MUST set the M bit of a Block2 Option to zero and the server MUST ignore it on reception." https://datatracker.ietf.org/doc/html/rfc7959#section-2.4
|
Thanks. The check failed because of coap.me down. |
|
Thanks for the quick turnaround! Could we also update the version to |
|
released: https://crates.io/crates/coap/0.19.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation copies the Block2 option from the response, increments the block number, and adds it to the next request in the block transfer. This is done when then M bit in the Block2 option from the response is set, which means that the bit is set when cloned and added back to the request. To be compliant with RFC-7959, set the M bit to zero before adding it back to the request.
Excerpt from RFC-7959:
"In a request, the client MUST set the M bit of a Block2 Option to zero and the server MUST ignore it on reception."
https://datatracker.ietf.org/doc/html/rfc7959#section-2.4