-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial enhance manual scan system #218
Merged
RadWolfie
merged 17 commits into
Cxbx-Reloaded:master
from
RadWolfie:enhance-manual-scan-system
Dec 13, 2024
Merged
Partial enhance manual scan system #218
RadWolfie
merged 17 commits into
Cxbx-Reloaded:master
from
RadWolfie:enhance-manual-scan-system
Dec 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…global variable cannot be used inside another global variable
…iles into source files
…ad of internal_LocateSymbolScan calls
…ent needed for internal_OOVPATableList_scan
…ame old reference to D3D_g_Stream_i_pVertexBuffer reference
…natures already have them implemented
5970d20
to
cd2fd18
Compare
Unit test on titles report back with no regressions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this pull request is to break away from using groups of OOVPA header files into their own source files. Doing this way will allow LTCG group to have their own respective versioning separated from non-LTCG group.
However, I also notice verification of two symbols are no longer needed as they are integrated into the OOVPA signatures. Which has been removed from this pull request. Plus, a correction of
D3D_g_Stream
reference internally properly reflects toD3D_g_Stream_i_pVertexBuffer
.