Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial enhance manual scan system #218

Merged
merged 17 commits into from
Dec 13, 2024

Conversation

RadWolfie
Copy link
Member

The goal of this pull request is to break away from using groups of OOVPA header files into their own source files. Doing this way will allow LTCG group to have their own respective versioning separated from non-LTCG group.

However, I also notice verification of two symbols are no longer needed as they are integrated into the OOVPA signatures. Which has been removed from this pull request. Plus, a correction of D3D_g_Stream reference internally properly reflects to D3D_g_Stream_i_pVertexBuffer.

@github-actions github-actions bot added OOVPA Any OOVPA change relative needs-verification Require verification before approval D3D8 OOVPA relative topic D3D8LTCG OOVPA relative topic CMAKE labels Dec 9, 2024
@RadWolfie RadWolfie force-pushed the enhance-manual-scan-system branch from 5970d20 to cd2fd18 Compare December 9, 2024 22:07
@RadWolfie RadWolfie removed the needs-verification Require verification before approval label Dec 13, 2024
@RadWolfie
Copy link
Member Author

Unit test on titles report back with no regressions.

@RadWolfie RadWolfie merged commit c59a1fa into Cxbx-Reloaded:master Dec 13, 2024
13 of 14 checks passed
@RadWolfie RadWolfie deleted the enhance-manual-scan-system branch December 13, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMAKE D3D8LTCG OOVPA relative topic D3D8 OOVPA relative topic OOVPA Any OOVPA change relative
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant