-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design API v3 #94
Design API v3 #94
Conversation
Currently, multi-thread support is not enabled for MSVC due to the developers haven't implemented C11 support in their compiler. From what I had read in the recent past, they're working on it and should be bundle in future Visual Studio 2019 update. |
Plus most importantly, include pointer to kernel thunk's address to translate internally for make stronger OOVPA signatures easier. 😄 |
If the team want to make the final decision for API's names later, please let me know here or on discord. Otherwise, we need to continue discussion what's need to be add/remove/update the parameters and/or API's names. |
Since the API naming and comments was changed since initialize commit. I do know initialize commit is working and had been verified using my unit test project locally. |
What's been change: Added:
Renamed:
EDIT: Also I have added a check to ensure steps are process correctly in order. Watch for error messages if you didn't perform the calls in right order. Internal functions has been renamed in second commit. Plus added:
|
NOTE: EDIT: I also had reran test with no issues. |
Fixed all reviews by @PatrickvL except one which is working as intended. Plus I discover a warning message from Visual Studio about memcpy usage over the limit. I have replaced memcpy to strncpy function for prevent warning and null'd the overflow. |
Design API v3.0
Closes #10
New features: (see XbSymbolDatabase.h file for functions' details)
Currently, the design is backward compatibility. Until final stage will move the old APIs into new APIs.