betterEmbedsYT: better video id extraction

Cynosphere · Feb 7, 2025 · f3a0dfc · f3a0dfc
1 parent df8a5d6
commit f3a0dfc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/betterEmbedsYT/manifest.json b/src/betterEmbedsYT/manifest.json
@@ -1,15 +1,15 @@
 {
   "$schema": "https://moonlight-mod.github.io/manifest.schema.json",
   "id": "betterEmbedsYT",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "meta": {
     "name": "Better YouTube Embeds",
     "tagline": "Bypass copyright blocks, descriptions, block ads and trackers (works with Watch Together).",
     "description": "Ad blocking uses code from the [Iridium](https://github.com/ParticleCore/Iridium) web extension.",
     "authors": ["Cynosphere"],
     "tags": ["qol", "privacy"],
     "source": "https://github.com/Cynosphere/moonlight-extensions",
-    "changelog": "Added option for showing descriptions"
+    "changelog": "Descriptions: Better video ID extraction"
   },
   "settings": {
     "description": {

diff --git a/src/betterEmbedsYT/webpackModules/description.tsx b/src/betterEmbedsYT/webpackModules/description.tsx
@@ -77,8 +77,8 @@ export default function DescriptionWrapper({
   embed: { rawDescription?: string; video: { url: string } };
   renderDescription: RenderDescription;
 }) {
-  const videoId = embed.video.url.split("/embed/").pop()!;
+  const videoId = embed.video.url.match(/\/embed\/([a-z0-9_\-]+)/i)?.[1];
   return embed.rawDescription == null ? null : (
-    <YTDescription description={embed.rawDescription} renderDescription={renderDescription} videoId={videoId} />
+    <YTDescription description={embed.rawDescription} renderDescription={renderDescription} videoId={videoId!} />
   );
 }