feature: new ui #44
Merged
feature: new ui #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cosmos-proposal-builder ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/components/BundleForm.tsx
Outdated
| <div className="space-y-12 sm:space-y-16"> | ||
| <div> | ||
| <h2 className="text-base font-semibold leading-7 text-gray-900"> | ||
| <h2 className="text-[28px] font-semibold text-[#0F3941]"> |
There was a problem hiding this comment.
Nice work! Can we add the new colors to tailwind.config.js, and refer to them by names?
Also seems you may need to -
- run
yarn lint:fix, and make sureyarn lintpasses (CI is failing) - rebase against
main- it seems your build does not include chore: bump ses #42 for some reason, as i seeTypeError#1: Accessor not expected at intrinsics.%IteratorPrototype%.constructorwhen visiting the netlify preview url
src/components/Tabs.tsx
Outdated
Comment on lines
48
to
51
| <div className="w-full max-w-4xl px-2 py-2 sm:px-0 m-auto"> | ||
| <Tab.Group selectedIndex={selectedIdx} onChange={handleChange}> | ||
| <Tab.List className="flex space-x-1 rounded-xl bg-teal-900/20 p-1"> | ||
| {tabs.map(({ title }) => ( | ||
| <Tab | ||
| key={title} | ||
| className={({ selected }) => | ||
| classNames( | ||
| "w-full rounded-lg py-2.5 text-sm font-medium leading-5 text-teal-700", | ||
| "ring-white ring-opacity-60 ring-offset-2 ring-offset-teal-400 focus:outline-none focus:ring-2", | ||
| selected | ||
| ? "bg-white shadow" | ||
| : "text-teal-100 hover:bg-white/[0.12] hover:text-white", | ||
| ) | ||
| } | ||
| > | ||
| {title} | ||
| </Tab> | ||
| ))} | ||
| </Tab.List> | ||
| <Tab.Panels className="mt-6"> | ||
| {tabs.map(({ content }, idx) => ( | ||
| <Tab.Panel | ||
| key={idx} | ||
| unmount={false} | ||
| className="flex flex-col min-w-full rounded-xl bg-white p-3" | ||
| > | ||
| {content} | ||
| </Tab.Panel> | ||
| ))} | ||
| </Tab.Panels> | ||
| <div className={"flex flex-wrap rounded-xl bg-white"}> | ||
| <div className={"basis-full md:basis-5/12 md:p-[40px]"}> |
There was a problem hiding this comment.
Can we adjust this so more screen width is used? Currently seeing ~896px used on desktop where I'd expect to see ~1200px.
screenshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.