To support using shapely object to manipulate database geometry data. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ryan-kipawa There is build error. Please check the detail. The typing caused this failure. How to fix it?
|
|
I think we should use ruff's nice suggestion here of https://docs.astral.sh/ruff/rules/unused-import/ With this we could remove the import of shapely all together, as well as the try_import method. Findspec essentially accomplished the same thing. |
|
I haven't used the importlib.util.findspec, the test always fail says that he model has not to_wkt property. sys.modules.get works well. The import process has been removed. Please review it again. @ryan-kipawa |
ryan-kipawa
reviewed
Nov 21, 2024
|
@ryan-kipawa Test for shapely geometry has been added. |
ryan-kipawa
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ryan-kipawa I just modified the notebook to add some example of shapely object usage. If the testing needed to be added for testpy, then the action of build should also be modified. Please let me know your opinion.