Merge pull request #473 from DHI/netcdf_dependency

Make netcdf mandatory
DHI · Dec 12, 2024 · 05a6eee · 05a6eee
2 parents dd4122b + a34fc98
commit 05a6eee
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/full_test.yml b/.github/workflows/full_test.yml
@@ -35,11 +35,11 @@ jobs:
     - name: Install modelskill
       run: |
         pip install .[test]
-    - name: Static type check
-      run: make typecheck
     - name: Test with pytest
       run: |
         pytest --cov=modelskill --ignore tests/notebooks/
+    - name: Static type check
+      run: make typecheck
     - name: Test docstrings with pytest
       run: |
         pytest ./modelskill/metrics.py --doctest-modules
diff --git a/pyproject.toml b/pyproject.toml
@@ -14,6 +14,7 @@ dependencies = [
     "mikeio >= 1.2",
     "matplotlib",
     "xarray",
+    "netCDF4",
     "scipy",
     "jinja2",
 ]
@@ -52,7 +53,6 @@ dev = ["pytest",
 test =  [
             "pytest",
             "pytest-cov", 
-            "netCDF4",
             "openpyxl",
             "dask",
             "mypy",