Run less in CI #310
Open
Run less in CI #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsmariegaard
reviewed
Dec 8, 2023
.github/workflows/notebooks_test.yml
Outdated
| @@ -8,6 +8,7 @@ on: | |||
|
|
|||
| jobs: | |||
| build: | |||
| if: '! github.event.pull_request.draft' | |||
There was a problem hiding this comment.
ChatGPT tells me it should be [ready-for-review] 😉
There was a problem hiding this comment.
I don't think you should put such critical business decisions in the hands of AI. It makes stuff up.
The event is called ready_for_review (i.e. with underscores)
We tried that before, ready_for_review is an event that happens once, which might be good enough, but what if you start changing stuff based on the review, then this event is a bit too early.
There was a problem hiding this comment.
How about this?
on:
pull_request:
types: [opened, reopened, synchronize, ready_for_review]
jobs:
your_job:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
There was a problem hiding this comment.
Seems to work - the notebook test started
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.