Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistence using NetCDF groups #461

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Persistence using NetCDF groups #461

wants to merge 14 commits into from

Conversation

ecomodeller
Copy link
Member

@ecomodeller ecomodeller commented Oct 25, 2024

Should be cleaner than using a zip file.

This is a breaking change since it is not backwards compatible.

If useful, consider supporting both formats.

Any case, this PR is not be merged before we have released version 1.1.

Moreover, it requires xarray version > 2024.10.0 which Requires: Python >=3.10😳

@ecomodeller
Copy link
Member Author

One line in a notebook is failing

cmp.where(cmp.data.windsector=="W").plot.timeseries();

I can't see that it is related to the changes in this PR, except for the new version of xarray.

@ecomodeller
Copy link
Member Author

Seems like there is some kind of agreement in the scientific Python community to support three year old Python versions https://scientific-python.org/specs/spec-0000/

Which would exclude 3.9 released in October 2020.

@ecomodeller
Copy link
Member Author

ecomodeller commented Jan 29, 2025

TODO:

  • Re-enable legacy persistence method using zip file.
  • convert persisted datasets to use groups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant