Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure executor attributes are defined by subclasses #524

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

quantum5
Copy link
Member

@quantum5 quantum5 commented Oct 4, 2019

No description provided.

@quantum5 quantum5 requested review from Xyene and xiaowuc1 October 4, 2019 22:12
@codecov-io
Copy link

codecov-io commented Oct 4, 2019

Codecov Report

Merging #524 into master will increase coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #524      +/-   ##
==========================================
+ Coverage   72.78%   72.96%   +0.17%     
==========================================
  Files         126      127       +1     
  Lines        3925     3958      +33     
==========================================
+ Hits         2857     2888      +31     
- Misses       1068     1070       +2
Impacted Files Coverage Δ
dmoj/executors/compiled_executor.py 94.78% <100%> (ø) ⬆️
dmoj/executors/mixins.py 93.33% <100%> (ø) ⬆️
dmoj/executors/metaclass.py 100% <100%> (ø)
dmoj/utils/unicode.py 77.77% <0%> (ø) ⬆️
dmoj/executors/base_executor.py 78.44% <0%> (+0.45%) ⬆️
dmoj/cptbox/tracer.py 83.16% <0%> (+0.49%) ⬆️
dmoj/checkers/sorted.py 96.55% <0%> (+1.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36b9519...d00b0f8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants