Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow artifacts_path to be defined as ENV #940

Merged
merged 2 commits into from
Feb 12, 2025
Merged

feat: allow artifacts_path to be defined as ENV #940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
686b3a0
allow the artifacts_path to be defined as ENV
dolfim-ibm Feb 11, 2025
8acd9aa
add check if artifacts_path exists and is dir
dolfim-ibm Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docling/datamodel/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import sys
from pathlib import Path
from typing import Annotated, Tuple
from typing import Annotated, Optional, Tuple

from pydantic import BaseModel, PlainValidator
from pydantic_settings import BaseSettings, SettingsConfigDict
Expand Down Expand Up @@ -62,6 +62,7 @@ class AppSettings(BaseSettings):
debug: DebugSettings

cache_dir: Path = Path.home() / ".cache" / "docling"
artifacts_path: Optional[Path] = None


settings = AppSettings(perf=BatchConcurrencySettings(), debug=DebugSettings())
8 changes: 8 additions & 0 deletions docling/pipeline/standard_pdf_pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,14 @@ def __init__(self, pipeline_options: PdfPipelineOptions):
artifacts_path: Optional[Path] = None
if pipeline_options.artifacts_path is not None:
artifacts_path = Path(pipeline_options.artifacts_path).expanduser()
elif settings.artifacts_path is not None:
artifacts_path = Path(settings.artifacts_path).expanduser()

if artifacts_path is not None and not artifacts_path.is_dir():
raise RuntimeError(
f"The value of {artifacts_path=} is not valid. "
"When defined, it must point to a folder containing all models required by the pipeline."
)

self.keep_images = (
self.pipeline_options.generate_page_images
Expand Down