Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 9167c49 to allow calling run ... internally #603

Merged
merged 6 commits into from
Jan 12, 2025
Merged

Conversation

DannyBen
Copy link
Owner

@DannyBen DannyBen commented Jan 8, 2025

cc #602
reverts 9167c49

This PR moves the globals initialization from initialize back to run, where they were originally.
This is done in order to allow developers to simply call run ARGS... from any of their own function to execute their own functions using the same public CLI syntax.

  • Implementation
  • Existing tests pass
  • Define this behavior as a formal feature:
    • New tests
    • Documentation - the example is sufficient as we do not want to encourage this pattern

@DannyBen DannyBen added this to the 1.2.8 milestone Jan 8, 2025
@DannyBen DannyBen merged commit cdf17b6 into master Jan 12, 2025
9 checks passed
@DannyBen DannyBen deleted the revert/9167c49 branch January 12, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant