add ac-3/ec-3 support

Dash-Industry-Forum · Dec 30, 2024 · 0c4bb67 · 0c4bb67
1 parent 14e9f6d
commit 0c4bb67
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/cmd/cmaf-ingest-receiver/app/channel.go b/cmd/cmaf-ingest-receiver/app/channel.go
@@ -180,7 +180,7 @@ func (ch *channel) addInitDataAndUpdateTimescale(stream stream, init *mp4.InitSe
 
 	ch.addTrData(r)
 	switch sampleEntry {
-	case "avc1", "hvc1", "mp4a", "stpp", "wvtt":
+	case "avc1", "hvc1", "mp4a", "ac-3", "ec-3", "stpp", "wvtt":
 		// OK
 	case "evte": // Event stream. Don't add to MPD or contentinfo, but keep the segments.
 		// TODO. Handle event streams for SCTE-35 events and other cases

diff --git a/cmd/livesim2/app/asset.go b/cmd/livesim2/app/asset.go
@@ -568,7 +568,7 @@ func (a *asset) generateTimelineEntriesFromRef(refSE segEntries, repID string) s
 			t = nextT
 		}
 	}
-	return se
+	return se, nil
 }
 
 func (a *asset) setReferenceRep() error {
@@ -706,6 +706,9 @@ func (r RepData) sampleDur() uint32 {
 	switch {
 	case strings.HasPrefix(r.Codecs, "mp4a.40") && r.MediaTimescale == 48000:
 		return 1024
+	// TODO support other timescale such as 32kHz and 44.1kHz
+	case (strings.HasPrefix(r.Codecs, "ac-3") || strings.HasPrefix(r.Codecs, "ec-3")) && r.MediaTimescale == 48000:
+		return 1536
 	default:
 		return 0
 	}