Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converter: Support Defined but empty components #33930

Merged
merged 4 commits into from
Feb 14, 2025

Conversation

mackjmr
Copy link
Member

@mackjmr mackjmr commented Feb 11, 2025

What does this PR do?

Previously, when a component config section was defined but empty, this lead to the component not being added.
e.g. if you had extensions defined as so:

extensions:

Then we wouldn't add the extensions to this, but we would add them to the pipelines, which would lead to otel-agent failing to start.

This PR fixes this bug (the type assertion to map was failing when the section is left empty).

This PR addresses this for processors, receivers and extensions. exporters and connectors are not affected because we don't add these component types in converter.

Motivation

OTAGENT-269

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@mackjmr mackjmr requested review from a team as code owners February 11, 2025 14:52
@mackjmr mackjmr requested review from IbraheemA and truthbk February 11, 2025 14:52
@github-actions github-actions bot added team/opentelemetry OpenTelemetry team medium review PR review might take time labels Feb 11, 2025
@mackjmr mackjmr added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Feb 11, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 11, 2025

Uncompressed package size comparison

Comparison with ancestor 977c866e0bc32772570a414922b36d6facf25021

Diff per package
package diff status size ancestor threshold
datadog-agent-aarch64-rpm 0.00MB 863.87MB 863.87MB 0.50MB
datadog-agent-arm64-deb 0.00MB 854.12MB 854.12MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 59.04MB 59.04MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.12MB 59.12MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.12MB 59.12MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.53MB 56.53MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 440.97MB 440.97MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 86.36MB 86.36MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 86.43MB 86.43MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 86.42MB 86.42MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 82.62MB 82.62MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 82.69MB 82.69MB 0.50MB
datadog-agent-x86_64-rpm -0.00MB 875.37MB 875.37MB 0.50MB
datadog-agent-x86_64-suse -0.00MB 875.37MB 875.37MB 0.50MB
datadog-agent-amd64-deb -0.00MB 865.60MB 865.60MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 11, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=55939420 --os-family=ubuntu

Note: This applies to commit 0db5e3e

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 11, 2025

Static quality checks ✅

Please find below the results from static quality gates

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 836.85MiB 858.45MiB 202.86MiB 214.3MiB
static_quality_gate_docker_agent_amd64 921.66MiB 942.69MiB 308.66MiB 321.56MiB
static_quality_gate_docker_agent_arm64 934.04MiB 952.69MiB 292.63MiB 351.22MiB
static_quality_gate_docker_agent_jmx_amd64 1.09GiB 1.11GiB 383.73MiB 395.8MiB
static_quality_gate_docker_agent_jmx_arm64 1.09GiB 1.11GiB 363.72MiB 375.5MiB
static_quality_gate_docker_dogstatsd_amd64 47.86MiB 57.88MiB 18.29MiB 28.29MiB
static_quality_gate_docker_dogstatsd_arm64 46.26MiB 56.27MiB 17.06MiB 27.06MiB
static_quality_gate_docker_cluster_agent_amd64 267.69MiB 277.7MiB 107.27MiB 117.28MiB
static_quality_gate_docker_cluster_agent_arm64 283.74MiB 293.73MiB 102.11MiB 112.12MiB

Copy link

cit-pr-commenter bot commented Feb 11, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 4ea41d69-456f-4d72-bcc0-3b19225927cd

Baseline: 977c866
Comparison: 0db5e3e
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +3.62 [+0.52, +6.72] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.17 [-0.29, +0.63] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.17 [-0.61, +0.95] 1 Logs
file_tree memory utilization +0.10 [+0.04, +0.17] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.07 [-0.86, +0.99] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.03 [-0.91, +0.97] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.02 [-0.88, +0.92] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.26, +0.27] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.02 [-0.66, +0.62] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.02 [-0.74, +0.71] 1 Logs
quality_gate_idle_all_features memory utilization -0.05 [-0.13, +0.02] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput -0.26 [-1.03, +0.51] 1 Logs
quality_gate_idle memory utilization -0.49 [-0.53, -0.46] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization -0.60 [-1.49, +0.28] 1 Logs
tcp_syslog_to_blackhole ingress throughput -2.58 [-2.68, -2.49] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

Copy link
Contributor

@ogaca-dd ogaca-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

if components == nil {
// components map is nil. It is defined but section is empty.
// need to create map manually
stringMapConf[comp.Type] = make(map[string]any)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
stringMapConf[comp.Type] = make(map[string]any)
componentsMap = make(map[string]any)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 0db5e3e 👍

@mackjmr
Copy link
Member Author

mackjmr commented Feb 14, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 14, 2025

View all feedbacks in Devflow UI.
2025-02-14 14:23:46 UTC ℹ️ Start processing command /merge


2025-02-14 14:23:52 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-02-14 15:22:05 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 33m.


2025-02-14 15:50:28 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 4161833 into main Feb 14, 2025
225 of 231 checks passed
@dd-mergequeue dd-mergequeue bot deleted the mackjmr/converter-support-defined-but-empty branch February 14, 2025 15:50
@github-actions github-actions bot added this to the 7.64.0 milestone Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/opentelemetry OpenTelemetry team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants