Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up integration tests #1673

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shuheiktgw
Copy link
Collaborator

@shuheiktgw shuheiktgw commented Feb 9, 2025

What does this PR do?

I've fixed the following two issues related to the integration tests:

  1. Currently, users need to manually install Kubernetes binaries using setup-envtest to run the integration tests. It would be better if these binaries were installed automatically when needed.
  2. The Makefile has two targets related to integration tests: integration and integration_v2. However, there don't seem to be any tests associated with the integration tag. So, I promoted integration_v2 to integration and removed the integration_v2 target.

Thanks for your review!

Motivation

Cleaning up integration tests and making it easier to run them.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@shuheiktgw shuheiktgw requested a review from a team as a code owner February 9, 2025 09:13
@shuheiktgw shuheiktgw force-pushed the clean_up_integration_tests branch from c64b8db to 2972c87 Compare February 9, 2025 09:20
@shuheiktgw shuheiktgw requested a review from a team as a code owner February 9, 2025 09:20
@jhgilbert jhgilbert self-assigned this Feb 10, 2025
@jhgilbert jhgilbert removed their assignment Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants