Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing group resource to allow groups with periods #1697

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adel121
Copy link
Contributor

@adel121 adel121 commented Feb 14, 2025

What does this PR do?

Fixes bug in parsing group resource parsing that prevented parsing groups containing periods correctly.

Motivation

Fix the issue.

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Same testing plan as this

But, here we should test with a resource of which the api group contains periods.

For example, you can use this:

apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: example-ingress
  namespace: default
spec:
  rules:
  - host: example.com
    http:
      paths:
      - path: /
        pathType: Prefix
        backend:
          service:
            name: example-service
            port:
              number: 80

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@adel121 adel121 added the enhancement New feature or request label Feb 14, 2025
@adel121 adel121 added this to the v1.13.0 milestone Feb 14, 2025
@adel121 adel121 requested a review from a team as a code owner February 14, 2025 14:34
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.30%. Comparing base (1c16822) to head (9900edb).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1697      +/-   ##
==========================================
- Coverage   49.33%   49.30%   -0.03%     
==========================================
  Files         219      219              
  Lines       21314    21299      -15     
==========================================
- Hits        10515    10502      -13     
+ Misses      10252    10250       -2     
  Partials      547      547              
Flag Coverage Δ
unittests 49.30% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...troller/datadogagent/feature/enabledefault/rbac.go 12.12% <100.00%> (-3.59%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c16822...9900edb. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants