Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 128bit trace ID logging by default #3116

Draft
wants to merge 2 commits into
base: v2-dev
Choose a base branch
from

Conversation

mtoffl01
Copy link
Contributor

@mtoffl01 mtoffl01 commented Jan 23, 2025

What does this PR do?

Logs contain the full 128bits of the trace id by default. Can be disabled with DD_TRACE_128_BIT_TRACEID_LOGGING_ENABLED=false. Feature applies to tracer logs as well as our supported logger integrations: slog and logrus.

Motivation

Config consistency

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@mtoffl01 mtoffl01 changed the base branch from main to v2-dev January 23, 2025 21:50
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Jan 23, 2025
@pr-commenter
Copy link

pr-commenter bot commented Jan 23, 2025

Benchmarks

Benchmark execution time: 2025-01-28 22:22:59

Comparing candidate commit d0ee2a1 in PR branch mtoff/v2-log128bits with baseline commit 7d516f3 in branch v2-dev.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 2 unstable metrics.

scenario:BenchmarkSetTagString-24

  • 🟩 execution_time [-7.368ns; -4.732ns] or [-6.009%; -3.859%]

@mtoffl01 mtoffl01 changed the title Enable 128bit trace ID logging by defaul Enable 128bit trace ID logging by default Jan 24, 2025
@mtoffl01 mtoffl01 marked this pull request as ready for review January 28, 2025 16:50
@mtoffl01 mtoffl01 requested review from a team as code owners January 28, 2025 16:50
@mtoffl01 mtoffl01 marked this pull request as draft January 28, 2025 21:02
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 28, 2025

Datadog Report

Branch report: mtoff/v2-log128bits
Commit report: e104d03
Test service: dd-trace-go

✅ 0 Failed, 4098 Passed, 64 Skipped, 2m 46.29s Total Time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant