Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(net/http: orchestrion): obfuscate query string parameters when auto-instrumenting #3127

Merged

Conversation

RomainMuller
Copy link
Contributor

What does this PR do?

Retrofits #3071 into the orchestrion specification.

Motivation

This puts automatic instrumentation on par with manual instrumentation.
This is necessary for the upcoming orchestrion system tests to pass.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@RomainMuller RomainMuller requested review from a team as code owners January 29, 2025 11:47
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Jan 29, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 29, 2025

Datadog Report

Branch report: romain.marcadier/orchestrion-obfuscate-client-query
Commit report: 639f860
Test service: dd-trace-go

✅ 0 Failed, 5215 Passed, 73 Skipped, 2m 19.6s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jan 29, 2025

Benchmarks

Benchmark execution time: 2025-01-29 13:30:47

Comparing candidate commit a2fcb94 in PR branch romain.marcadier/orchestrion-obfuscate-client-query with baseline commit 46362ed in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics.

@RomainMuller RomainMuller requested a review from a team as a code owner January 29, 2025 12:44
@RomainMuller RomainMuller force-pushed the romain.marcadier/orchestrion-obfuscate-client-query branch 2 times, most recently from cfe434b to 1e45218 Compare January 29, 2025 13:00
@RomainMuller RomainMuller force-pushed the romain.marcadier/orchestrion-obfuscate-client-query branch from 1e45218 to a2fcb94 Compare January 29, 2025 13:04
@RomainMuller RomainMuller enabled auto-merge (squash) January 29, 2025 13:24
@RomainMuller RomainMuller merged commit ddfe2d4 into main Jan 29, 2025
176 checks passed
@RomainMuller RomainMuller deleted the romain.marcadier/orchestrion-obfuscate-client-query branch January 29, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants