Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix incorrect filepath to multios test xml #3153

Merged
merged 9 commits into from
Feb 7, 2025

Conversation

hannahkm
Copy link
Contributor

@hannahkm hannahkm commented Feb 5, 2025

What does this PR do?

Fixes an issue in which reporting codeowners was not accommodating XMLs located in the root directory, since we would previously cd to a different folder.

Also, adds a continue-on-error:true to the test-multi-os job. This line is present in other testing files (i.e. unit-integration-tests). According to these docs, it would allow jobs to continue even if test-multi-os fails. Although this does not have an impact on the jobs in this file, since there is only one job (which is test-multi-os), it may be nice to have consistency between our test jobs runs.

Motivation

Fix test reporting and make the behavior of each testing job the same. Previously, codeowners were never being reported for test-multi-os jobs since the xml file could not be detected.

Other jobs within the Main Branch and Release Tests pipeline do not exit if there is a failure. We hope that adding this line will allow all tests to be reported correctly.

The new reporting was tested by running the Main Branch and Release Tests pipeline on this branch and checking to confirm that Test Code Owners was populated in the Datadog CI:

image image image

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 5, 2025

Datadog Report

Branch report: hannahkm/continue-on-error-multios
Commit report: cfc1944
Test service: dd-trace-go

✅ 0 Failed, 5226 Passed, 73 Skipped, 1m 50.65s Total Time

@hannahkm hannahkm changed the title ci: add continue-on-error for multios tests ci: fix incorrect filepath to multios test xml Feb 5, 2025
@pr-commenter
Copy link

pr-commenter bot commented Feb 5, 2025

Benchmarks

Benchmark execution time: 2025-02-07 15:00:21

Comparing candidate commit c31ee9f in PR branch hannahkm/continue-on-error-multios with baseline commit f11947f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 0 unstable metrics.

@hannahkm hannahkm marked this pull request as ready for review February 5, 2025 21:54
@hannahkm hannahkm requested review from a team as code owners February 5, 2025 21:54
@hannahkm hannahkm enabled auto-merge (squash) February 6, 2025 20:43
@hannahkm hannahkm merged commit 4a72a09 into main Feb 7, 2025
176 checks passed
@hannahkm hannahkm deleted the hannahkm/continue-on-error-multios branch February 7, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants