-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix incorrect filepath to multios test xml #3153
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 5226 Passed, 73 Skipped, 1m 50.65s Total Time |
BenchmarksBenchmark execution time: 2025-02-07 15:00:21 Comparing candidate commit c31ee9f in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 0 unstable metrics. |
What does this PR do?
Fixes an issue in which reporting
codeowners
was not accommodating XMLs located in the root directory, since we would previouslycd
to a different folder.Also, adds a
continue-on-error:true
to thetest-multi-os
job. This line is present in other testing files (i.e.unit-integration-tests
). According to these docs, it would allow jobs to continue even iftest-multi-os
fails. Although this does not have an impact on the jobs in this file, since there is only one job (which istest-multi-os
), it may be nice to have consistency between our test jobs runs.Motivation
Fix test reporting and make the behavior of each testing job the same. Previously,
codeowners
were never being reported fortest-multi-os
jobs since thexml
file could not be detected.Other jobs within the
Main Branch and Release Tests
pipeline do not exit if there is a failure. We hope that adding this line will allow all tests to be reported correctly.The new reporting was tested by running the
Main Branch and Release Tests
pipeline on this branch and checking to confirm thatTest Code Owners
was populated in the Datadog CI:Reviewer's Checklist
v2-dev
branch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!