Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: implement DD_TRACE_INTEGRATION_TAGS + contrib/net/http support #3156

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rarguelloF
Copy link
Contributor

What does this PR do?

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Feb 6, 2025
@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: rarguelloF/poc-env-integration-config
Commit report: d7bb46b
Test service: dd-trace-go

❌ 1 Failed (0 Known Flaky), 5222 Passed, 73 Skipped, 1m 16.41s Total Time

❌ Failed Tests (1)

  • TestServeMuxNoRace - gopkg.in/DataDog/dd-trace-go.v1/contrib/net/http - Details

    Expand for error
     Failed
     
     === RUN   TestServeMuxNoRace
     component=net/http;http.request.method=GET;server.address=;server.port=;span.kind=server;url.path=/
     component=net/http;http.request.method=GET;server.address=;server.port=;span.kind=server;url.path=/
     ==================
     Read at 0x00c0003135f0 by goroutine 78:
       runtime.mapaccess2_faststr()
           /opt/hostedtoolcache/go/1.22.12/x64/src/runtime/map_faststr.go:108 +0x0
       gopkg.in/DataDog/dd-trace-go.v1/internal.(*IntegrationTags).Get()
     ...
    

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant