Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Operation Name Mappings Migration Guide #27530

Merged
merged 6 commits into from
Feb 14, 2025
Merged

New Operation Name Mappings Migration Guide #27530

merged 6 commits into from
Feb 14, 2025

Conversation

brett0000FF
Copy link
Contributor

What does this PR do? What is the motivation?

  • New guide instructing how to opt-in to new operation name mappings.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@github-actions github-actions bot added the Guide Content impacting a guide label Feb 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

New or renamed files

Modified Files

@brett0000FF
Copy link
Contributor Author

brett0000FF commented Feb 10, 2025 •
edited
Loading

@IbraheemA - Thanks for drafting this guide! I'm adding it to our docs and I've applied some edits.

Two questions for you:

  • We have instructions for replacing SpanNameAsResourceName and SpanNameRemappings, but we only have info for the Collector. Do we need instructions for the Agent as well?
    Added note to Agent section "If you previously used span name configurations and need to maintain similar functionality, set the operation.name attribute directly in your application code."
  • How committed are we to the April 2025 deadline? We typically don't mention specific dates in our docs. This will eventually get out of date, and it also holds us to a deadline we may not want. What do you think?
    Removed specific date; replaced with "in the near future".

@brett0000FF brett0000FF added the editorial review Waiting on a more in-depth review label Feb 11, 2025
@brett0000FF brett0000FF marked this pull request as ready for review February 11, 2025 21:43
@brett0000FF brett0000FF requested a review from a team as a code owner February 11, 2025 21:43
joepeeples
joepeeples approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, but since I'm unfamiliar with this functionality I wasn't sure how crucial any of them would be. Thanks!

@brett0000FF
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 14, 2025 •
edited
Loading

View all feedbacks in Devflow UI.
2025-02-14 23:01:26 UTC ℹ️ Start processing command /merge

2025-02-14 23:01:44 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 7m.

2025-02-14 23:07:25 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 137776b into master Feb 14, 2025
14 of 16 checks passed
@dd-mergequeue dd-mergequeue bot deleted the brett.blue/migrate-operation-names branch February 14, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IbraheemA IbraheemA IbraheemA approved these changes

@joepeeples joepeeples joepeeples approved these changes

Assignees
No one assigned
Labels
editorial review Waiting on a more in-depth review Guide Content impacting a guide mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brett0000FF @IbraheemA @joepeeples