Merge pull request #379 from DataDog/s.obregoso/fix_domainregistration

Fixing the timezone in dns lookups

.gitignore

@@ -12,5 +12,5 @@ wheels/
 *.egg-info/
 build/
 .coverage*
-.cache
 .semgrep
+.cache

guarddog/analyzer/metadata/utils.py

@@ -1,4 +1,4 @@
-from datetime import datetime
+from datetime import datetime, timezone
 from functools import cache
 from typing import Optional
 
@@ -29,7 +29,7 @@ def get_domain_creation_date(domain) -> tuple[Optional[datetime], bool]:
     except whois.parser.PywhoisError as e:
         # The domain doesn't exist at all, if that's the case we consider it vulnerable
         # since someone could register it
-        return None, (not str(e).lower().startswith('no match for'))
+        return None, (not str(e).lower().startswith("no match for"))
 
     if domain_information.creation_date is None:
         # No creation date in whois, so we can't know
@@ -38,7 +38,8 @@ def get_domain_creation_date(domain) -> tuple[Optional[datetime], bool]:
     creation_dates = domain_information.creation_date
 
     if type(creation_dates) is list:
-        return min(creation_dates), True
+        # TZ info is updated to turn all dates into TZ aware so we can compare them
+        return min([d.replace(tzinfo=timezone.utc) for d in creation_dates]), True
 
     return creation_dates, True