Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] fix #584 Add Wifi Setting Page #666

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

[WIP] fix #584 Add Wifi Setting Page #666

wants to merge 7 commits into from

Conversation

yoshida0261
Copy link
Contributor

@yoshida0261 yoshida0261 commented Jan 30, 2020 •
edited
Loading

Issue

Overview (Required)

  • Add a WiFi item to the navigation drawer.
  • Tap the WiFi item
    • Connect to the venue's WiFi using WifiManager.

Screenshot

Before After

TODO

@takahirom
Copy link
Member

takahirom commented Jan 30, 2020 •
edited
Loading

Thanks for sharing the draft!!
It would be nice if you could go to that screen from the about screen.

@jmatsu-bot
Copy link
Collaborator

No issue was reported. Cool!

Generated by 🚫 Danger

@takahirom
Copy link
Member

The implementation of the about page is fine. 👍

@jmatsu-bot
Copy link
Collaborator

Your apk has been deployed to https://deploygate.com/distributions/467060db36bf4cb7f187464dc4f6f26bb5ca6b5c. Anyone can try your changes via the link.

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Wifi Setting Page
3 participants
@yoshida0261 @takahirom @jmatsu-bot