-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: code coverage #1207
Merged
Merged
chore: code coverage #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eoxelements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
silvester-pari
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this deep-dive! It was quite tricky, but I think this is now a great addition to our toolset. Now the only thing left to do is writing more tests 😝
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented changes
This PR adds code coverage to our cypress tests using Istanbul (https://github.com/ifaxity/vite-plugin-istanbul)
TODO:
How to use:
npm run test:component
(this will generate acoverage
and a.nyc_output
folder that contain info about our code coveragenpm run nyc:report
to show a summary of code coverageopening
coverage/lcov-report/index.html
opens a nice interface where we can view coverage information for each filecoverage is also added as a step in our
run-tests
pipeline (https://github.com/EOX-A/EOxElements/actions/runs/10873667192/job/30170032260?pr=1207), the "Code coverage" step displays the output of thenpm run nyc:report
command and the "Upload code coverage" step uploads thecoverage/lcov-report
folder as an artifactCloses #638
Screenshots/Videos
Checklist before requesting a review