Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

light.yaml use min_brightness and max_brightness as conditions instead of "while true" loops #660

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Nicolai-
Copy link

@Nicolai- Nicolai- commented Jan 7, 2025

Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! 🎉
Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.

Sections marked as * are required and need to be filled in.

Proposed change*

Use available min/max brightness values as failsafe/safeguards instead of "while true" loops.

Iv'e encountered the issue while creating/testing new controllers, if a "release" event is not sent for long presses.
Then my z2m network is flooded cause of the "while true" loop.

Checklist*

  • I followed sections of the Contribution Guidelines relevant to changes I'm proposing.
  • I properly tested proposed changes on my system and confirm that they are working as expected.
  • I formatted files with Prettier using the command npm run format before submitting my Pull Request.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Hey @Nicolai-, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant