Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook light color temp #671

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

hudecof
Copy link

@hudecof hudecof commented Jan 16, 2025

Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! 🎉
Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.

Sections marked as * are required and need to be filled in.

Breaking change

Removed the transition from the light.turn_off service. The EGLO lights will not turn off event if the transition is set to 0.

Handling the color temperature with attribute color_temp_kelvin.

Proposed change*

Better handling the color temperature with color_temp_kelvin.
Setting the boundaries from the attributes min_color_temp_kelvin and min_color_temp_kelvin.
Adding the *Color Temperature Steps for long and short press as for the brightness.

Previous handling by the color_temp without boundaries reflected the device temperature leaded the confiding the blueprint is not working the the value was changes too high/low by pressing the button. This reflects more the HA Light Card for this device.

Checklist*

  • I followed sections of the Contribution Guidelines relevant to changes I'm proposing.
  • I properly tested proposed changes on my system and confirm that they are working as expected.
  • I formatted files with Prettier using the command npm run format before submitting my Pull Request.

Copy link
Contributor

Hey @hudecof, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant