Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2166 #2167

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Fix 2166 #2167

merged 1 commit into from
Feb 7, 2025

Conversation

jajhall
Copy link
Member

@jajhall jajhall commented Feb 7, 2025

Although #2166 is not an issue, it highlighted that Gurobi reads MPS keywords in mixed case, so convert to upper case in HiGHS for comparisons

@jajhall jajhall changed the base branch from master to latest February 7, 2025 11:58
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.69%. Comparing base (ed7323b) to head (e515dca).
Report is 3 commits behind head on latest.

Files with missing lines Patch % Lines
src/io/HMpsFF.cpp 96.55% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #2167      +/-   ##
==========================================
+ Coverage   78.68%   78.69%   +0.01%     
==========================================
  Files         345      345              
  Lines       83126    83135       +9     
==========================================
+ Hits        65408    65426      +18     
+ Misses      17718    17709       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jajhall jajhall merged commit 6e1f916 into latest Feb 7, 2025
274 of 275 checks passed
@jajhall jajhall deleted the fix-2166 branch February 7, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant