Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 2122 #2168

Merged
merged 13 commits into from
Feb 8, 2025
Merged

Fix issue 2122 #2168

merged 13 commits into from
Feb 8, 2025

Conversation

fwesselm
Copy link
Collaborator

@fwesselm fwesselm commented Feb 8, 2025

Fix #2122

  • Method HighsTransformedLp::transform() assumes that variable bound constraints are tight, which may not be true if improved column bounds were found during cut generation.
  • Testing on 800+ MIPs did not reveal severe regressions.
  • I added a test.

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 92.15686% with 8 lines in your changes missing coverage. Please review.

Project coverage is 78.75%. Comparing base (e515dca) to head (3ff15e4).
Report is 15 commits behind head on latest.

Files with missing lines Patch % Lines
src/mip/HighsImplications.cpp 92.00% 4 Missing ⚠️
src/mip/HighsTransformedLp.cpp 66.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #2168      +/-   ##
==========================================
+ Coverage   78.69%   78.75%   +0.05%     
==========================================
  Files         345      345              
  Lines       83135    83165      +30     
==========================================
+ Hits        65426    65498      +72     
+ Misses      17709    17667      -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jajhall jajhall merged commit eee9e39 into ERGO-Code:latest Feb 8, 2025
119 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants