Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added kImplicitInteger to definition of HighsVarType for highspy #2170

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

jajhall
Copy link
Member

@jajhall jajhall commented Feb 8, 2025

No description provided.

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.75%. Comparing base (3ff15e4) to head (60df046).
Report is 3 commits behind head on latest.

Additional details and impacted files
@@           Coverage Diff           @@
##           latest    #2170   +/-   ##
=======================================
  Coverage   78.75%   78.75%           
=======================================
  Files         345      345           
  Lines       83165    83165           
=======================================
  Hits        65498    65498           
  Misses      17667    17667           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jajhall jajhall merged commit 9456074 into latest Feb 8, 2025
275 checks passed
@jajhall jajhall deleted the fix-2169 branch February 8, 2025 17:55
@odow
Copy link
Collaborator

odow commented Feb 8, 2025

Question: when should we use kImplicitInteger instead of kInteger?

@jajhall
Copy link
Member Author

jajhall commented Feb 8, 2025

Users shouldn't use kImplicitInteger when defining models: it's an artefact of presolve.

It's a continuous variable that, by implication, must take an integer value. For example, if it is the only continuous variable in an equation with integer coefficients and RHS. The fact that it can only take integer values is exploited in the MIP solver. For example, if a domain placed it in an interval interior to consecutive integer, then the corresponding node would be infeasible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants