Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 2171 #2183

Merged
merged 13 commits into from
Feb 19, 2025
Merged

Fix issue 2171 #2183

merged 13 commits into from
Feb 19, 2025

Conversation

fwesselm
Copy link
Collaborator

Fix #2171

  • Correct update of bounds on constraint activities for rounded column bounds in HPresolve::transformColumn().
  • Check if rows are redundant in HPresolve::strengthenInequalities() and let HPresolve::rowPresolve() handle such rows.
  • Added a test.
  • Testing on 800+ MIPs showed that around 30 instances are affected by these changes. The shifted geometric means of the running times and branching nodes look reasonable.

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 95.58824% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.82%. Comparing base (7f90d45) to head (1293a1d).
Report is 18 commits behind head on latest.

Files with missing lines Patch % Lines
src/simplex/HEkk.cpp 0.00% 2 Missing ⚠️
src/qpsolver/a_asm.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #2183      +/-   ##
==========================================
+ Coverage   78.81%   78.82%   +0.01%     
==========================================
  Files         345      345              
  Lines       83165    83179      +14     
==========================================
+ Hits        65544    65564      +20     
+ Misses      17621    17615       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jajhall jajhall merged commit 1fd953d into ERGO-Code:latest Feb 19, 2025
119 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants