ElmerGui, minor fix to account for toLower() of FDNEUT, must compare the #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
input to lower case 'fdneut'. Needed in order to successfully load any FDNEUT input file.
|
FDNEUT is associated to Fidap FEM software which was one of the early CFD software living still in early 2000's but is now dead. Perhaps the ability to read these files could be removed. |
|
As preparation for removing FDNEUT, perhaps a message like 'FDNEUT is no longer supported and may be removed in the future', would make sense. Any other input formats for ElmerGrid or ElmerGui that may be candidates for the same message? |
|
Yes, maybe it would make sense to study all the formats at once and see which may have become obsolite. On the other hand there may be some single users that build their workflow on old formats so it is difficult to know this for sure. So maybe we let things be as they are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
input to lower case 'fdneut'. Needed in order to successfully load any FDNEUT input file.