Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functions doc #5483

Merged
merged 4 commits into from
Feb 18, 2025
Merged

Functions doc #5483

merged 4 commits into from
Feb 18, 2025

Conversation

ZZZank
Copy link
Contributor

@ZZZank ZZZank commented Feb 18, 2025

This is a "distilled" version of #5444 , basically guaranteed to be safe, because changes here will only be one of:

  1. function body is not changed, only JSDoc added
  2. function body changed, but logic is the same
  3. function moved from one place to another
  4. function rewritten, but tested by myself ingame

Note that most JSDoc needs ProbeJS Legacy to actually work

@ZZZank ZZZank mentioned this pull request Feb 18, 2025
Closed
NielsPilgaard
NielsPilgaard approved these changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@NielsPilgaard NielsPilgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😊

@NielsPilgaard NielsPilgaard merged commit 126869c into EnigmaticaModpacks:master Feb 18, 2025
@ZZZank ZZZank deleted the functions-doc branch February 19, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NielsPilgaard NielsPilgaard NielsPilgaard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZZZank @NielsPilgaard