Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(input-time-picker): add hour-format property #10059

Open
wants to merge 58 commits into
base: dev
Choose a base branch
from
Open

feat(input-time-picker): add hour-format property #10059

wants to merge 58 commits into from
+1,411 −898

Commits on Jul 29, 2024

  1. removing redundant call to updateLocale since connectLocalized calls … 

    …it already
    @eriklharper
    eriklharper committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    667a48f View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Merge branch 'dev' of github.com:Esri/calcite-design-system into erik… 

    …lharper/4756-time-picker-24-hour-support
    @eriklharper
    eriklharper committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    4450b62 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. adding hour12 option to formatter factory function

    @eriklharper
    eriklharper committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    6711efe View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. updating input-time-picker's displayed value when the hour-cycle prop… 

    …erty changes
    @eriklharper
    eriklharper committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    046099c View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. fixing bug where decrementing the hour in time-picker with a starting… 

    … value of 0:0:0 resulted in a clearing of the value
    @eriklharper
    eriklharper committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    840e425 View commit details
    Browse the repository at this point in the history

  2. mostly have this working, but did a refactor to DRY up all the places… 

    … where we need to set the localized input value. Also fixed a place where localized meridiem wasn't being set properly.
    @eriklharper
    eriklharper committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    7efb5c6 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. making numberingSystem optional in the DateTimeFormatter function so … 

    …we can determine hourcycle from just the locale. Refactored input-time-picker to match time-picker in how it updates locale state when it changes, including setting a default hourCycle when one is not provided.
    @eriklharper
    eriklharper committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    2420c2c View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2024

  1. not by any means a permanent solution, but kinda works as a springboa… 

    …rd to something better
    @eriklharper
    eriklharper committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    953b85a View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. updated demo html page to include an opposite hour format example for… 

    … each locale
    @eriklharper
    eriklharper committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    e2ea8ee View commit details
    Browse the repository at this point in the history

  2. updating typing to use SupportedLocale in place of generic string whe… 

    …re appropriate
    @eriklharper
    eriklharper committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    a6bdc45 View commit details
    Browse the repository at this point in the history

  3. undoing last change on 2 files that don't have other diffs

    @eriklharper
    eriklharper committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    9cbed7a View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. moving logic further ahead by mutating the localeConfig formats based… 

    … on hourCycle. Not perfectly working, but we'll need this to get to the next step which is to parse both 12 and 24 hour formats. Fixing Arabic locale time format overrides to match ICU.
    @eriklharper
    eriklharper committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    3be5ad7 View commit details
    Browse the repository at this point in the history

  2. fixing mk locale time format bug in chromium

    @eriklharper
    eriklharper committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    b7fa174 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. refactoring locale config modification logic to minimize deep propert… 

    …y access
    @eriklharper
    eriklharper committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    78af8a5 View commit details
    Browse the repository at this point in the history

  2. fixing issue where popup won't close on blur when committed value is … 

    …not a valid time
    @eriklharper
    eriklharper committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    4fed0e4 View commit details
    Browse the repository at this point in the history

  3. haven't thoroughly tested it, but dual hour format parsing seems to b… 

    …e working regardless of hourCycle!
    @eriklharper
    eriklharper committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    f4f8e5d View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. organizing input time picker tests into better describe blocks

    @eriklharper
    eriklharper committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    a7118ff View commit details
    Browse the repository at this point in the history

  2. adding prevent default describe block

    @eriklharper
    eriklharper committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    5b41686 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2024

  1. adding getLocalizedMeridiem function with full locale tests for use l… 

    …ater in the e2e typing tests
    @eriklharper
    eriklharper committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    a94f2c9 View commit details
    Browse the repository at this point in the history

  2. fixing issue where hitting enter on a cleared input doesn't set the v… 

    …alue to nil. Also adding comprehensive locale typing tests, need to expand a bit more and fix a few locales still
    @eriklharper
    eriklharper committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    3c89657 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. fixing bug with bulgarian locale omitting the "ч." character in chromium

    @eriklharper
    eriklharper committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    a3465d9 View commit details
    Browse the repository at this point in the history

  2. fixing outstanding bugs with typing in 24-hour format in 12-hour defa… 

    …ult locales by correcting the regex to capture whitespace characters on either side of the meridiem tokens in the time format string
    @eriklharper
    eriklharper committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    203b2da View commit details
    Browse the repository at this point in the history

  3. updating getMeridiemOrder to force 12 hour clock and adding additiona… 

    …l supported locales to test that render meridiem to the left of the time value
    @eriklharper
    eriklharper committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    26fa833 View commit details
    Browse the repository at this point in the history

  4. setting up 12-hour parsing for 24-hour locales, although dayjs doesn'… 

    …t seem to like a lot of the localized meridiem formats, so we may want to ship this with the caveat that it might not work just right for all locales
    @eriklharper
    eriklharper committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    f772b60 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. removing bulgarian hour character since we're only using short and me… 

    …dium time
    @eriklharper
    eriklharper committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    5602b1c View commit details
    Browse the repository at this point in the history

  2. adding blur test for 24 hour cycle

    @eriklharper
    eriklharper committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    e7f11ae View commit details
    Browse the repository at this point in the history

  3. removing all redundant typing tests in favor of the one that tests al… 

    …l the locales
    @eriklharper
    eriklharper committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    765aea3 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. remove dual hourCycle parsing logic

    @eriklharper
    eriklharper committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    d8e1a91 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. renaming hourCycle to hourFormat

    @eriklharper
    eriklharper committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    dd855cd View commit details
    Browse the repository at this point in the history

  2. making locale type more specific

    @eriklharper
    eriklharper committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    de08dc6 View commit details
    Browse the repository at this point in the history

  3. fixing last remnants of hour-cycle

    @eriklharper
    eriklharper committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    267eada View commit details
    Browse the repository at this point in the history

  4. Merge branch 'dev' of github.com:Esri/calcite-design-system into erik… 

    …lharper/4756-time-picker-24-hour-support
    @eriklharper
    eriklharper committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    167c341 View commit details
    Browse the repository at this point in the history

  5. good start to parsing 12-hour format for 24-hour locales

    @eriklharper
    eriklharper committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    9567668 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. fixing chromium bug with missing macedonia 12 hour meridiems and simp… 

    …lifying the hour and meridiem regexes
    @eriklharper
    eriklharper committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    98205a0 View commit details
    Browse the repository at this point in the history

  2. consolidated e2e tests to handle initial display, committing with ent… 

    …er key and committing on blur using selectText util
    @eriklharper
    eriklharper committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    1baf41f View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. fixing e2e tests and mk and bs locale chromium bugs

    @eriklharper
    eriklharper committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    643b9f6 View commit details
    Browse the repository at this point in the history

  2. fixing broken hebrew 12-hour test. Simplifies the regex for replacing… 

    … localized am and pm by removing the space, negating the need to consider the meridiem order.
    @eriklharper
    eriklharper committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    5626570 View commit details
    Browse the repository at this point in the history

  3. taking into account whether there is whitespace between the meridiem … 

    …and other elements in the format token replacement logic
    @eriklharper
    eriklharper committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    75aa5a7 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. fixing es-mx 12-hour parsing bug in local browser. Still isn't passin… 

    …g in the e2e test environment, so need to figure out how to workaround this
    @eriklharper
    eriklharper committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    44e833d View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. fixing russian meridiem parsing

    @eriklharper
    eriklharper committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    eb5fa49 View commit details
    Browse the repository at this point in the history

  2. fixing pt-pt broken test

    @eriklharper
    eriklharper committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    57afbc7 View commit details
    Browse the repository at this point in the history

  3. fixing zh-CN 12-hour parsing bug

    @eriklharper
    eriklharper committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    e39a8a5 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. fixing 12-hour parsing in norwegian. 24-hour parsing is currently bro… 

    …ken, so need to fix that up next
    @eriklharper
    eriklharper committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    c872b71 View commit details
    Browse the repository at this point in the history

  2. fixing japanese 12 hour parsing

    @eriklharper
    eriklharper committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    e567c74 View commit details
    Browse the repository at this point in the history

  3. removing unused code

    @eriklharper
    eriklharper committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    a17f7f8 View commit details
    Browse the repository at this point in the history

  4. fixing norwegian 12 and 24 hour parsing!

    @eriklharper
    eriklharper committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    9a76e32 View commit details
    Browse the repository at this point in the history

  5. cleaning up logic for 24-hour test

    @eriklharper
    eriklharper committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    406da26 View commit details
    Browse the repository at this point in the history

  6. fixing es-MX 24-hour parsing test failure

    @eriklharper
    eriklharper committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    3d63fab View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. making some test variables more semantic

    @eriklharper
    eriklharper committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    8b22a61 View commit details
    Browse the repository at this point in the history

  2. fixing broken arabic 12-hour parsing test. getMeridiemOrder needs to … 

    …preserve the order coming back from Intl.DateTimeFormat
    @eriklharper
    eriklharper committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    6c4c46e View commit details
    Browse the repository at this point in the history

  3. fixing remaining broken tests, with exemptions for es-MX which in the… 

    … test environment is formatting as if it was es, refactoring demo page to work in Firefox and Safari
    @eriklharper
    eriklharper committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    09ea769 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'dev' into eriklharper/4756-time-picker-24-hour-support

    @eriklharper
    eriklharper authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    7b170fa View commit details
    Browse the repository at this point in the history

  5. no longer need to export LocalizeTimeStringParameters type

    @eriklharper
    eriklharper committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    28c7081 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'eriklharper/4756-time-picker-24-hour-support' of github… 

    ….com:Esri/calcite-design-system into eriklharper/4756-time-picker-24-hour-support
    @eriklharper
    eriklharper committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    6674c3e View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Reword documentation for hour-format property 

    Co-authored-by: Kitty Hurley <[email protected]>
    @eriklharper @geospatialem
    eriklharper and geospatialem authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    728fa1a View commit details
    Browse the repository at this point in the history

  2. Reword documentation for hour-format property 

    Co-authored-by: Kitty Hurley <[email protected]>
    @eriklharper @geospatialem
    eriklharper and geospatialem authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    8bd6d23 View commit details
    Browse the repository at this point in the history

  3. Ensuring the meridiem appears in the correct place when dir="rtl". Fi… 

    …xes a broken test in time-picker.
    @eriklharper
    eriklharper committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    57a92c4 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'eriklharper/4756-time-picker-24-hour-support' of github… 

    ….com:Esri/calcite-design-system into eriklharper/4756-time-picker-24-hour-support
    @eriklharper
    eriklharper committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    91daaf5 View commit details
    Browse the repository at this point in the history