Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump ws and puppeteer #9994

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 8, 2024

Bumps ws to 8.17.1 and updates ancestor dependency puppeteer. These dependencies need to be updated together.

Updates ws from 8.14.2 to 8.17.1

Release notes

Sourced from ws's releases.

8.17.1

Bug fixes

  • Fixed a DoS vulnerability (#2231).

A request with a number of headers exceeding the[server.maxHeadersCount][] threshold could be used to crash a ws server.

const http = require('http');
const WebSocket = require('ws');
const wss = new WebSocket.Server({ port: 0 }, function () {
const chars = "!#$%&'*+-.0123456789abcdefghijklmnopqrstuvwxyz^_`|~".split('');
const headers = {};
let count = 0;
for (let i = 0; i < chars.length; i++) {
if (count === 2000) break;
for (let j = 0; j &lt; chars.length; j++) {
  const key = chars[i] + chars[j];
  headers[key] = 'x';
if (++count === 2000) break;
}

}
headers.Connection = 'Upgrade';
headers.Upgrade = 'websocket';
headers['Sec-WebSocket-Key'] = 'dGhlIHNhbXBsZSBub25jZQ==';
headers['Sec-WebSocket-Version'] = '13';
const request = http.request({
headers: headers,
host: '127.0.0.1',
port: wss.address().port
});
request.end();
});

The vulnerability was reported by Ryan LaPointe in websockets/ws#2230.

In vulnerable versions of ws, the issue can be mitigated in the following ways:

  1. Reduce the maximum allowed length of the request headers using the [--max-http-header-size=size][] and/or the [maxHeaderSize][] options so that no more headers than the server.maxHeadersCount limit can be sent.

... (truncated)

Commits
  • 3c56601 [dist] 8.17.1
  • e55e510 [security] Fix crash when the Upgrade header cannot be read (#2231)
  • 6a00029 [test] Increase code coverage
  • ddfe4a8 [perf] Reduce the amount of crypto.randomFillSync() calls
  • b73b118 [dist] 8.17.0
  • 29694a5 [test] Use the highWaterMark variable
  • 934c9d6 [ci] Test on node 22
  • 1817bac [ci] Do not test on node 21
  • 96c9b3d [major] Flip the default value of allowSynchronousEvents (#2221)
  • e5f32c7 [fix] Emit at most one event per event loop iteration (#2218)
  • Additional commits viewable in compare view

Updates puppeteer from 21.5.0 to 23.0.1

Release notes

Sourced from puppeteer's releases.

puppeteer-core: v23.0.1

23.0.1 (2024-08-07)

Bug Fixes

puppeteer: v23.0.1

23.0.1 (2024-08-07)

Miscellaneous Chores

  • puppeteer: Synchronize puppeteer versions

Dependencies

  • The following workspace dependencies were updated
    • dependencies
      • puppeteer-core bumped from 23.0.0 to 23.0.1

puppeteer-core: v23.0.0

23.0.0 (2024-08-07)

⚠ BREAKING CHANGES

  • remove deprecated Frame.isOOPFrame() (#12897)
  • use Uint8Array instead of Buffer for browser compatibility (#12823)
  • remove isIncognito (#12830)
  • support multiple browser downloads for Puppeteer (#12795)
  • remove deprecated functions for CustomQueryHandler (#12824)
  • rename ignoreHttpsErrors to acceptInsecureCerts (#12756)
  • rename product to browser (#12757)
  • default to WebDriver BiDi for Firefox (#12732)
  • replace dynamic imports with static dependency injection (#12710)
  • remove whitespace normalization from a11y selectors (#12693)

Features

... (truncated)

Commits
Maintainer changes

This version was pushed to npm by google-wombot, a new releaser for puppeteer since your current version.


You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [ws](https://github.com/websockets/ws) to 8.17.1 and updates ancestor dependency [puppeteer](https://github.com/puppeteer/puppeteer). These dependencies need to be updated together.


Updates `ws` from 8.14.2 to 8.17.1
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@8.14.2...8.17.1)

Updates `puppeteer` from 21.5.0 to 23.0.1
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json)
- [Commits](puppeteer/puppeteer@puppeteer-v21.5.0...puppeteer-v23.0.1)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
- dependency-name: puppeteer
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 8, 2024
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Aug 15, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 21, 2024

Dependabot timed out while waiting for a private package registry. Because of this, Dependabot cannot update this pull request.

5 similar comments
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 21, 2024

Dependabot timed out while waiting for a private package registry. Because of this, Dependabot cannot update this pull request.

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 22, 2024

Dependabot timed out while waiting for a private package registry. Because of this, Dependabot cannot update this pull request.

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 22, 2024

Dependabot timed out while waiting for a private package registry. Because of this, Dependabot cannot update this pull request.

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 22, 2024

Dependabot timed out while waiting for a private package registry. Because of this, Dependabot cannot update this pull request.

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 22, 2024

Dependabot timed out while waiting for a private package registry. Because of this, Dependabot cannot update this pull request.

@github-actions github-actions bot removed the Stale Issues or pull requests that have not had recent activity. label Aug 23, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 23, 2024

Dependabot timed out while waiting for a private package registry. Because of this, Dependabot cannot update this pull request.

15 similar comments
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 27, 2024

Dependabot timed out while waiting for a private package registry. Because of this, Dependabot cannot update this pull request.

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 27, 2024

Dependabot timed out while waiting for a private package registry. Because of this, Dependabot cannot update this pull request.

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 27, 2024

Dependabot timed out while waiting for a private package registry. Because of this, Dependabot cannot update this pull request.

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 27, 2024

Dependabot timed out while waiting for a private package registry. Because of this, Dependabot cannot update this pull request.

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 28, 2024

Dependabot timed out while waiting for a private package registry. Because of this, Dependabot cannot update this pull request.

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 28, 2024

Dependabot timed out while waiting for a private package registry. Because of this, Dependabot cannot update this pull request.

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 30, 2024

Dependabot timed out while waiting for a private package registry. Because of this, Dependabot cannot update this pull request.

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 30, 2024

Dependabot timed out while waiting for a private package registry. Because of this, Dependabot cannot update this pull request.

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 30, 2024

Dependabot timed out while waiting for a private package registry. Because of this, Dependabot cannot update this pull request.

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 31, 2024

Dependabot timed out while waiting for a private package registry. Because of this, Dependabot cannot update this pull request.

Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 3, 2024

Dependabot timed out while waiting for a private package registry. Because of this, Dependabot cannot update this pull request.

Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 3, 2024

Dependabot timed out while waiting for a private package registry. Because of this, Dependabot cannot update this pull request.

Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 4, 2024

Dependabot timed out while waiting for a private package registry. Because of this, Dependabot cannot update this pull request.

Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 4, 2024

Dependabot timed out while waiting for a private package registry. Because of this, Dependabot cannot update this pull request.

Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 4, 2024

Dependabot timed out while waiting for a private package registry. Because of this, Dependabot cannot update this pull request.

Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 5, 2024

Dependabot timed out while waiting for a private package registry. Because of this, Dependabot cannot update this pull request.

Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Stale Issues or pull requests that have not had recent activity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants