Get exact char instead of last for /pay modifier; Added pay-modifier-enabled config line

[AjMaacc]

Information

This PR closes #5495

Details

Proposed feature:

This feature allows the ability to enable/disable usage of /pay modifiers such as 1k, 1m, 1b ,1t
Along with that when the command is checking for those modifiers, it checks the first char after the number instead of the last.

Environments tested:

OS: Linux

Java version: 17

• Most recent Paper version (1.20.1, git-Paper-145)
• CraftBukkit/Spigot/Paper 1.12.2
• CraftBukkit 1.8.8

Demonstration:

[pop4959]

Fundamentally this doesn't change anything, the same manipulation can be done with the first character as the last character. A proper fix is checking for exactly the modifier, and if anything else is entered reject the input.

[pop4959]

Also worth considering if pay modifiers should even be enabled by default.

[AjMaacc]

Fundamentally this doesn't change anything, the same manipulation can be done with the first character as the last character. A proper fix is checking for exactly the modifier, and if anything else is entered reject the input.

I agree with only looking for the exact char. Would it be better to just ignore the modifier if it is not exact?

Also worth considering if pay modifiers should even be enabled by default.

I'll have it default false

[pop4959]

I agree with only looking for the exact char. Would it be better to just ignore the modifier if it is not exact?

I think it's safer to throw an exception there, and not assume the modifier (or no modifier) that the user intended to send if it's invalid. This shouldn't happen often, and showing an error will allow the user to make corrections and send the correct amount.

[pop4959]

Couple minor things, overall looks fine to me

[AjMaacc]

Resolved Issues