some cleanups #3195
Open
some cleanups #3195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3195 +/- ##
==========================================
- Coverage 63.94% 63.93% -0.01%
==========================================
Files 104 104
Lines 21757 21753 -4
Branches 10635 10635
==========================================
- Hits 13912 13908 -4
+ Misses 5639 5637 -2
- Partials 2206 2208 +2 ☔ View full report in Codecov by Sentry. |
neheb
force-pushed
the
un
branch
4 times, most recently
from
9ca891e to
59d583a
Compare
|
Fun fact about the solaris stuff. There's no way it works. I added CI in my repo and there's no linking done towards libsocket. |
neheb
force-pushed
the
un
branch
4 times, most recently
from
ed383a9 to
a953d94
Compare
|
Not sure about the config.h change. |
neheb
force-pushed
the
un
branch
5 times, most recently
from
3ae3ed4 to
dbf9d4e
Compare
It's threadsafe and is a simple one liner. A bunch of code is needed when not using fmt. Make that clear. Also replace tm with std::tm. Confusing otherwise. Signed-off-by: Rosen Penev <[email protected]>
Signed-off-by: Rosen Penev <[email protected]>
Signed-off-by: Rosen Penev <[email protected]>
Signed-off-by: Rosen Penev <[email protected]>
Precomputed the second one instead of adding parentheses. Godbolt shows a savings of two instructions on x86. Signed-off-by: Rosen Penev <[email protected]>
clang-tidy complains about the result of release() being unused. Signed-off-by: Rosen Penev <[email protected]>
clang-tidy complains about it. Signed-off-by: Rosen Penev <[email protected]>
Signed-off-by: Rosen Penev <[email protected]>
Became unused from all the stringFormat conversions Signed-off-by: Rosen Penev <[email protected]>
meson has this quirk where it tests default, hidden, and internal. If one fails, they all fail. We don't care about hidden and internal. Signed-off-by: Rosen Penev <[email protected]>
No need with std::filesystem Signed-off-by: Rosen Penev <[email protected]>
This is C++20 now. Signed-off-by: Rosen Penev <[email protected]>
Signed-off-by: Rosen Penev <[email protected]>
This was committed accidentally Signed-off-by: Rosen Penev <[email protected]>
Signed-off-by: Rosen Penev <[email protected]>
Signed-off-by: Rosen Penev <[email protected]>
Not having the else after return is fine for normal if statements, but not if constexpr. Fixes an MSVC warning about an unreachable path. Signed-off-by: Rosen Penev <[email protected]>
No need for find_if's overhead. Signed-off-by: Rosen Penev <[email protected]>
Signed-off-by: Rosen Penev <[email protected]>
A boneheaded mistake when converting std::exp and std::log(2). exp2 is simpler. Signed-off-by: Rosen Penev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.