Landing page improvements #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edwarnicke @nealtex01 took at really quick shot at #112 doing mostly the layouts.
|
|
@sknat Good start :) Next up the arrows between the icons? @nealtex01 do you have a better source for icons? |
|
Can do, I didn't for now as it is a bit tedious to build it and make it reactive. |
sknat
force-pushed
the
new-landing
branch
3 times, most recently
from
973662b to
378ae43
Compare
dwallacelf
reviewed
Feb 24, 2023
dwallacelf
reviewed
Feb 24, 2023
dwallacelf
reviewed
Feb 24, 2023
dwallacelf
requested changes
Feb 24, 2023
There was a problem hiding this comment.
There is also a dead link on the HICN Documentation page:
Documentation -> HICN Documentation -> 'Blog post' : https://deploy-preview-114--fdio.netlify.app/latest/news/hicn
This patch refactors the whole architecture of the repository - The landing page is not templated anymore in order to allow for more flexibiltiy for the time being. - Bootstrap version is bumped to 5.0 - Dependancies on proprietary themes is dropped. Signed-off-by: Nathan Skrzypczak <[email protected]>
Signed-off-by: Nathan Skrzypczak <[email protected]>
|
Thanks @dwallacelf for the review, |
dwallacelf
approved these changes
Feb 27, 2023
|
Hi SimardeepSingh1450,
These documents are quite old, we've merged a refactoring of the fd.io<http://fd.io> website based on these two presentations.
I guess moving forward we should open a discussion - i.e. a new issue - to prioritise future evolutions.
Cheers
-Nathan
On 11 May 2023, at 23:10, SimardeepSingh1450 ***@***.******@***.***>> wrote:
@sknat<https://github.com/sknat> @edwarnicke<https://github.com/edwarnicke> I have went through the files : https://docs.google.com/presentation/d/1OPqjiJYdtaEUjWqRYAk27ctbZg-OiZktSNF12hXq7J4/edit#slide=id.p
https://docs.google.com/presentation/d/1928l56YGFk9oBuWaAx0FRzZBUUnGnIJDOxb1qMzaj-c/edit#slide=id.g100f35f23ab_2_24
And can help i contribute in someway 😄?
—
Reply to this email directly, view it on GitHub<#114 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAZ5XZFXUAJIVSQ7DZDQTYLXFVIWBANCNFSM5IQZSWZQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@sknat Sure, I would like to contribute to some issues, or open some issues if i find some problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first shot at issue #112 visuals are preliminary, for the sake of discussion.
Signed-off-by: Nathan Skrzypczak [email protected]