Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FormSum weights #335

Merged
merged 6 commits into from
Jan 15, 2025

Conversation

pbrubeck
Copy link
Contributor

@pbrubeck pbrubeck commented Dec 21, 2024

FormSum weights were left out in most parts of the code.

@pbrubeck pbrubeck force-pushed the pbrubeck/fix/formsum-weights branch 3 times, most recently from 2e46852 to ff69060 Compare December 22, 2024 01:08
@pbrubeck pbrubeck force-pushed the pbrubeck/fix/formsum-weights branch 2 times, most recently from e1c1211 to 6d8989a Compare December 27, 2024 23:45
Copy link
Collaborator

@dham dham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please to be adding tests

@pbrubeck pbrubeck force-pushed the pbrubeck/fix/formsum-weights branch from 7665c2d to dc43bb1 Compare January 9, 2025 10:07
@pbrubeck pbrubeck requested a review from dham January 9, 2025 10:24
@jhale jhale enabled auto-merge January 9, 2025 12:12
@jhale jhale added this pull request to the merge queue Jan 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 14, 2025
@jorgensd jorgensd added this pull request to the merge queue Jan 15, 2025
Merged via the queue into FEniCS:main with commit f39f8f4 Jan 15, 2025
12 checks passed
@pbrubeck pbrubeck deleted the pbrubeck/fix/formsum-weights branch January 15, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants