Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix S3 download #2228

Open
wants to merge 2 commits into
base: dev/v0.7.0
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Support zip file without .zip suffix
Raphael-Jin committed Oct 3, 2024
commit eeb5ee04f6293387bfdea7f298ef224587178839
Original file line number Diff line number Diff line change
@@ -205,6 +205,16 @@ def retrieve_and_unzip_package(self, package_name, package_url):
os.remove(local_package_file)
ssl._create_default_https_context = ssl._create_unverified_context

# HOT FIX:
print("HOT FIX: package_url: ", package_url)

# we detect a substring called: "?X-Amz-Algorithm="
# we remove this substring and everything after it
if "?X-Amz-Algorithm=" in package_url:
package_url = package_url.split("?X-Amz-Algorithm=")[0]

print("AFTER HOT FIX: package_url: ", package_url)

# Open a process to download the package so that we can avoid the request is blocked and check the timeout.
from multiprocessing import Process
completed_event = multiprocessing.Event()