Merged PR 730404: Enabling Skipped tests. They are passing. The tests…

… not stable will be Enabling Skipped tests. They are passing. The tests not stable will be investigated once they start failing again. On top of that it was added a configuration for code coverage setting.
Federico-Figalli · Mar 23, 2018 · 2c4c3da · 2c4c3da
1 parent e23cb46
commit 2c4c3da
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 61 deletions.
diff --git a/CodeCoverage.runsettings b/CodeCoverage.runsettings
@@ -36,6 +36,7 @@ Included items must then not match any entries in the exclude list to remain inc
                 <ModulePath>.*CPPUnitTestFramework.*</ModulePath>
                 <ModulePath>.*test\..*</ModulePath>
                 <ModulePath>.*windowsazure\..*</ModulePath>
+                <ModulePath>.*moq\..*</ModulePath>
               </Exclude>
             </ModulePaths>
 

diff --git a/edge-agent/test/Microsoft.Azure.Devices.Edge.Agent.Docker.Test/DockerEnvironmentTest.cs b/edge-agent/test/Microsoft.Azure.Devices.Edge.Agent.Docker.Test/DockerEnvironmentTest.cs
@@ -29,8 +29,6 @@ public class DockerEnvironmentTest
         const string OperatingSystemType = "linux";
         const string Architecture = "x86_x64";
 
-        //TODO: INVESTIGATE/FIX AND ENABLE ASAP. Bug: 1912576
-        [Fact(Skip = "Failing, needs investigation.")]
         [Integration]
         public async Task TestEmptyEnvironment()
         {
@@ -42,8 +40,6 @@ public async Task TestEmptyEnvironment()
             }
         }
 
-        //TODO: INVESTIGATE/FIX AND ENABLE ASAP. Bug: 1912576
-        [Fact(Skip = "Failing, needs investigation.")]
         [Integration]
         public async Task TestPlatformInfo()
         {
@@ -61,8 +57,6 @@ public async Task TestPlatformInfo()
             }
         }
 
-        //TODO: INVESTIGATE/FIX AND ENABLE ASAP. Bug: 1912576
-        [Fact(Skip = "Failing, needs investigation.")]
         [Integration]
         public async Task TestFilters()
         {
@@ -127,8 +121,6 @@ public async Task TestFilters()
             }
         }
 
-        //TODO: INVESTIGATE/FIX AND ENABLE ASAP. Bug: 1912576
-        [Fact(Skip = "Failing, needs investigation.")]
         [Integration]
         public async Task TestEnvVars()
         {

diff --git a/edge-agent/test/Microsoft.Azure.Devices.Edge.Agent.Docker.Test/commands/PullCommandTest.cs b/edge-agent/test/Microsoft.Azure.Devices.Edge.Agent.Docker.Test/commands/PullCommandTest.cs
@@ -74,8 +74,6 @@ public async Task PullValidImages(string testFullImage, string image, string tag
             Assert.Equal(tag, testTag);
         }
 
-        //TODO: INVESTIGATE/FIX AND ENABLE ASAP. Bug: 1912576
-        [Fact(Skip = "Failing, needs investigation.")]
         [Integration]
         public async Task ImageNotFoundTest()
         {

diff --git a/edge-hub/test/Microsoft.Azure.Devices.Edge.Hub.Core.Test/storage/MessageStoreTest.cs b/edge-hub/test/Microsoft.Azure.Devices.Edge.Hub.Core.Test/storage/MessageStoreTest.cs
@@ -66,8 +66,6 @@ public async Task BasicTest()
             }
         }
 
-        //TODO: INVESTIGATE/FIX AND ENABLE ASAP. Bug: 1912576
-        [Fact(Skip = "Failing, needs investigation.")]
         public async Task CleanupTestTimeout()
         {
             (IMessageStore messageStore, ICheckpointStore checkpointStore) result = await this.GetMessageStore(20);
@@ -107,8 +105,6 @@ public async Task CleanupTestTimeout()
             }
         }
 
-        //TODO: INVESTIGATE/FIX AND ENABLE ASAP. Bug: 1912576
-        [Fact(Skip = "Failing, needs investigation.")]
         public async Task CleanupTestCheckpointed()
         {
             (IMessageStore messageStore, ICheckpointStore checkpointStore) result = await this.GetMessageStore(20);
@@ -150,53 +146,7 @@ public async Task CleanupTestCheckpointed()
                 Assert.Equal(0, batch.Count());
             }
         }
-
-        [Fact(Skip = "timing issues on build box")]
-        public async Task CleanupTestCheckpointAndTimeout()
-        {
-            (IMessageStore messageStore, ICheckpointStore checkpointStore) result = await this.GetMessageStore(180);
-            ICheckpointStore checkpointStore = result.checkpointStore;
-            using (IMessageStore messageStore = result.messageStore)
-            {
-                for (int i = 0; i < 100; i++)
-                {
-                    await messageStore.Add("module1", this.GetMessage(i));
-                }
-
-                await Task.Delay(TimeSpan.FromSeconds(10));
-
-                for (int i = 0; i < 100; i++)
-                {
-                    await messageStore.Add("module2", this.GetMessage(i));
-                }
-
-                IMessageIterator module2Iterator = messageStore.GetMessageIterator("module2");
-                IEnumerable<IMessage> batch = await module2Iterator.GetNext(100);
-                Assert.Equal(100, batch.Count());
-
-                IMessageIterator module1Iterator = messageStore.GetMessageIterator("module1");
-                batch = await module1Iterator.GetNext(100);
-                Assert.Equal(100, batch.Count());
-
-                await checkpointStore.SetCheckpointDataAsync("module2", new CheckpointData(99), CancellationToken.None);
-                await Task.Delay(TimeSpan.FromSeconds(130));
-
-                module2Iterator = messageStore.GetMessageIterator("module2");
-                batch = await module2Iterator.GetNext(100);
-                Assert.Equal(0, batch.Count());
-
-                module1Iterator = messageStore.GetMessageIterator("module1");
-                batch = await module1Iterator.GetNext(100);
-                Assert.Equal(100, batch.Count());
-
-                await Task.Delay(TimeSpan.FromSeconds(130));
-
-                module1Iterator = messageStore.GetMessageIterator("module1");
-                batch = await module1Iterator.GetNext(100);
-                Assert.Equal(0, batch.Count());
-            }
-        }
-
+
         IMessage GetMessage(int i)
         {
             return new Message(TelemetryMessageSource.Instance,