-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Move feature analytics to project level #5100
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Docker builds report
|
Moving comments from Matt here: This mostly looks good to me but I've added some thoughts / findings below.
![]()
![]()
|
Uffizzi Ephemeral Environment
|
1 - I'm not sure, let's have a discussion about this since one of our overall aims was to remove this confusion of project level feature things from environment feature value config |
Instead of keeping the current Analytics tab, I would prefer to have another way of accessing what's currently only inside the "⋮" dropdown button from the feature details modal as well. We already do this for "Copy feature name", which can be done by clicking the button next to the feature name, whether that's in the features list or a feature's details. IMO it's instinctive to click on a feature to do anything with it (like seeing analytics, history etc) and it's frustrating to have to remember that certain things are accessed from inside the modal, and others are from the features list dropdowns. I don't have a UX suggestion for how to achieve this (talk is cheap, I know). |
This train of thought is why I think keeping everything in the same place has the fewest downsides (i.e. this). The other options:
As you said, this means people are remembering its in a different page to where they are viewing the values of features.
This means everything is repeated, we introduce bloat, people will unnecessarily be opening another link from the feature modal to do what they need. |
Thanks for submitting a PR! Please check the boxes below:
docs/
if required so people know about the feature!Changes
Supersedes #5096
Moves feature analytics to separate nav. This may end up being a stop gap to where we have a project level "Features" navigation for create, settings and analytics vs the environment feature states.
How did you test this code?
Viewed feature analytics in production